From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp2130.oracle.com (aserp2130.oracle.com [141.146.126.79]) by sourceware.org (Postfix) with ESMTPS id 90136385BF9E for ; Mon, 10 May 2021 03:12:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 90136385BF9E Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 14A3CxoJ049527; Mon, 10 May 2021 03:12:59 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2130.oracle.com with ESMTP id 38dg5b9u2t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 May 2021 03:12:59 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 14A39jAE111103; Mon, 10 May 2021 03:12:58 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 38e5pu6yqk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 May 2021 03:12:58 +0000 Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 14A3Cv6G005593; Mon, 10 May 2021 03:12:57 GMT Received: from [10.39.218.69] (/10.39.218.69) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 09 May 2021 20:12:57 -0700 Subject: Re: [PATCH,V4 2/2] CTF: multi-CU and archive support To: Tom Tromey , Weimin Pan via Gdb-patches References: <1619485254-7340-1-git-send-email-weimin.pan@oracle.com> <1619485254-7340-2-git-send-email-weimin.pan@oracle.com> <1619485254-7340-3-git-send-email-weimin.pan@oracle.com> <87eeeh9e72.fsf@tromey.com> From: Wei-min Pan Message-ID: <83cb2b2f-97be-aa2c-82d2-6be769dbc7bb@oracle.com> Date: Sun, 9 May 2021 20:12:55 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <87eeeh9e72.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9979 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 spamscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105100023 X-Proofpoint-GUID: PyhTlzwrZFiEKVYTRIxf_683vSp_qWy_ X-Proofpoint-ORIG-GUID: PyhTlzwrZFiEKVYTRIxf_683vSp_qWy_ X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9979 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 spamscore=0 clxscore=1015 priorityscore=1501 adultscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 impostorscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105100023 X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 May 2021 03:13:00 -0000 On 5/8/2021 1:13 PM, Tom Tromey wrote: >>> + for (int i = 0; i < arch_cnt; ++i) >>> + { >>> + parent_pst->dependencies[i] >>> + = pcu.imported_symtabs.at (i); >>> + } > I forgot to mention -- don't use .at(), just use [] instead. > This loop could probably just be a memcpy or a std::copy, though an > explicit loop is also fine. OK, thanks. > > Tom