From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id D5FFB3858C78 for ; Mon, 11 Dec 2023 16:30:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D5FFB3858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D5FFB3858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702312248; cv=none; b=AwqATayqeP++FsiU95vRKjjiBNGgmC80y7g3Meq+oPNaPIyJpAszjKSGxaTSa4u0exf8sdSG6BYnTWAavLzdqFJaD1dC5+QS7onqPL0TkahChk9Ni16o9ecTV4d70idNgT6IV69/4o5Vk0vbyivuO/UaJ6uwJMYzwJrbkBQJA4U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702312248; c=relaxed/simple; bh=csavTS7J8E50RvxBlasVt/KhoMSTG8zLlYyr3u0+tys=; h=DKIM-Signature:Date:Message-Id:From:To:Subject:MIME-version; b=hYcyvSWrYV/+k1lxp2wCS3LUbScRCz/9iBs5qO+/hUMOv3mrirYIiBrBCYHH1HpmhJAyqrYZSYWeoCx/4Cr66aq9jkeNlTs4g1VBzi/Jn+E0cm88z/+NQ+rNQhR8uLCMzphfkt/8uS8BqJfMi7OZX31AK3iZoyW/Ok3UgmEcO3Q= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCjB7-0000yw-84; Mon, 11 Dec 2023 11:30:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=wrvsymvCmbbl9TgQyFqeyM/wgmdP8xY3zdHuo70r2/0=; b=YGLbJRRUdiB/Z+GalPQB EdvGMmT8Z4iOTTGO8nkXVnalqoJEOMSsQiubIEDgPaStTYWB3M9Jr8L1b7/rvPfFA2ru0LNiDlSY5 0aeuE7Nfa7zjhofUkMVSFIcViAHyQjLmckqqNw9NgCe44iCZoVFAhZ8gwd7oWOg/E2GBxJs3gCyBp 9ik6A+VXIh8qprjiYBEKuMHaVSCQMBNfwqffLZnPtcR7/lreTOqaBuEw5fQeatWI/3IT5xtTNUSsJ qbUrESnWwMyNXJcF4pWUdNTh9yFAvffLuAon4iq5Ocj8vv0/5gAC52BJ83JBqvMMYV90x5TDokDRL 6gkhCjS7hXTo9w==; Date: Mon, 11 Dec 2023 18:30:23 +0200 Message-Id: <83cyvcvh0g.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey Cc: gdb-patches@sourceware.org, legouguec@adacore.com In-Reply-To: <20231211-dap-cancel-v2-3-db7b52cf0329@adacore.com> (message from Tom Tromey on Mon, 11 Dec 2023 09:02:20 -0700) Subject: Re: [PATCH v2 3/6] Introduce gdb.interrupt References: <20231211-dap-cancel-v2-0-db7b52cf0329@adacore.com> <20231211-dap-cancel-v2-3-db7b52cf0329@adacore.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Tom Tromey > Date: Mon, 11 Dec 2023 09:02:20 -0700 > Cc: Eli Zaretskii , > Kévin Le Gouguec > > DAP cancellation needs a way to interrupt whatever is happening on > gdb's main thread -- whether that is the inferior, a gdb CLI command, > or Python code. > > This patch adds a new gdb.interrupt() function for this purpose. It > simply sets the quit flag and lets gdb do the rest. > > No tests in this patch -- instead this is tested via the DAP > cancellation tests. > > Reviewed-By: Eli Zaretskii > Reviewed-By: Kévin Le Gouguec > --- > gdb/NEWS | 3 +++ > gdb/doc/python.texi | 11 +++++++++++ > gdb/python/python.c | 19 +++++++++++++++++++ > 3 files changed, 33 insertions(+) Thanks, the documentation parts are approved. Reviewed-By: Eli Zaretskii