From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 1820F3858415 for ; Fri, 1 Dec 2023 15:58:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1820F3858415 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1820F3858415 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701446284; cv=none; b=TmO7sW/0xq4ulT7c/sc0jyZbqXv/25HPZIo37dqBoWonEpUMcsgawQmpmcZ7HnDcmuGy6IWpxPFGS7i4NmOO4bKHAQ8dfzbcertA0IWDyVno9tpIocU0zpDzvncQq2Z4SqilMyY5222SYcTXbTfyV15Yn1559lcVMfFsAmO9s5Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701446284; c=relaxed/simple; bh=RQoA762jXKcOeuPbcar2UdABx6L66517Uh977aR7aNg=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=waQC7syFd5NE08DhF85OxlBC7B1PPz1vucocLUO+JHC3jP9s/hi/esaLbwfRNeVYJ3nnZ/Sutl+1wLg9gFZV2DBaja8N5tN1oKxkKmZNK5h9zQobPRSheAW4OjsN2c7VIHAL1QkohPGm4neTgBISzgw46r9ttZoo6Ed/0IrFNBI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r95ty-0006GD-NH; Fri, 01 Dec 2023 10:58:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=NGIfB/b6FAX3t8psOG492PfKe/+pGwXclhHzGzf+kew=; b=QiQrlXjhBfml 8Z8Q+WhPOSiOxis/87m1pytgLLM2U82RDzAKI5LWEOmnYtjA6/DixVfLXkTht2f46SbW4TFMtdOT5 63HWtvYbe2rO/6eQozJCwA6Ht+R4khFfy/w5a/urKdIzkLlk0TnJxQQ3+rRCJycoQrSxvwKFDWX8c yvTBBdiZhbRp//96FxvK7APpbMCiug1HICJDY/U5kdoqys98ERzXw+tj4T8lemTDhmAl37dcKEATd WVyizUgflNCBSkRts09SqxNT27rRngWd9XcgaoxZSCxNM7wwS3/62Krc8H/q+6iqEOw4D/MZcjeYc KpJiHX6X9L1X9mO5fpLuJA==; Date: Fri, 01 Dec 2023 17:57:58 +0200 Message-Id: <83cyvpapa1.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey Cc: gdb-patches@sourceware.org In-Reply-To: <20231201-dap-cancel-v1-6-872022fc328a@adacore.com> (message from Tom Tromey on Fri, 01 Dec 2023 08:41:02 -0700) Subject: Re: [PATCH 6/6] Implement DAP cancellation References: <20231201-dap-cancel-v1-0-872022fc328a@adacore.com> <20231201-dap-cancel-v1-6-872022fc328a@adacore.com> X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Tom Tromey > Date: Fri, 01 Dec 2023 08:41:02 -0700 > > This implements DAP cancellation. A new object is introduced that > handles the details of cancellation. While cancellation is inherently > racy, this code attempts to make it so that gdb doesn't inadvertently > cancel the wrong request. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30472 > --- > gdb/doc/gdb.texinfo | 16 +++++++ > gdb/python/lib/gdb/dap/server.py | 91 ++++++++++++++++++++++++++++++++++++++-- > gdb/testsuite/gdb.dap/pause.exp | 71 +++++++++++++++++++++++++++++++ > 3 files changed, 175 insertions(+), 3 deletions(-) Thanks, the documentation part is OK. Reviewed-By: Eli Zaretskii