Re: [PATCH 4/5] Add "save skip" command

[Eli Zaretskii <eliz@gnu.org>]

> From: Tom Tromey <tom@tromey.com>
> Cc: Tom Tromey <tom@tromey.com>
> Date: Sun, 29 Jan 2023 09:21:04 -0700
> 
> PR cli/17997 points out that it would sometimes be convenient to save
> the current "skip"s to a file.  This patch implements this feature.
> 
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=17997
> ---
>  gdb/NEWS                        |  3 ++
>  gdb/doc/gdb.texinfo             |  6 +++
>  gdb/skip.c                      | 78 +++++++++++++++++++++++++++++++++
>  gdb/testsuite/gdb.base/skip.exp | 12 +++++
>  4 files changed, 99 insertions(+)

Thanks, the documentation parts are okay, with one comment:
> 
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -6707,6 +6707,12 @@ Set whether to print the debug output about skipping files and functions.
>  @item show debug skip
>  Show whether the debug output about skipping files and functions is printed.
>  
> +@kindex save skip
> +@item save skip @var{filename}
> +Save all skips to the file @var{filename}.  This command writes out
> +the skips as a script that can be re-read into @value{GDBN} using the
> +@code{source} command.

I wonder whether this new command should be described before "set/show
debug skip"?