public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 4/5] Add "save skip" command
Date: Sun, 29 Jan 2023 18:54:18 +0200	[thread overview]
Message-ID: <83cz6x703p.fsf@gnu.org> (raw)
In-Reply-To: <20230129162105.526266-5-tom@tromey.com> (message from Tom Tromey on Sun, 29 Jan 2023 09:21:04 -0700)

> From: Tom Tromey <tom@tromey.com>
> Cc: Tom Tromey <tom@tromey.com>
> Date: Sun, 29 Jan 2023 09:21:04 -0700
> 
> PR cli/17997 points out that it would sometimes be convenient to save
> the current "skip"s to a file.  This patch implements this feature.
> 
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=17997
> ---
>  gdb/NEWS                        |  3 ++
>  gdb/doc/gdb.texinfo             |  6 +++
>  gdb/skip.c                      | 78 +++++++++++++++++++++++++++++++++
>  gdb/testsuite/gdb.base/skip.exp | 12 +++++
>  4 files changed, 99 insertions(+)

Thanks, the documentation parts are okay, with one comment:
> 
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -6707,6 +6707,12 @@ Set whether to print the debug output about skipping files and functions.
>  @item show debug skip
>  Show whether the debug output about skipping files and functions is printed.
>  
> +@kindex save skip
> +@item save skip @var{filename}
> +Save all skips to the file @var{filename}.  This command writes out
> +the skips as a script that can be re-read into @value{GDBN} using the
> +@code{source} command.

I wonder whether this new command should be described before "set/show
debug skip"?

  reply	other threads:[~2023-01-29 16:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-29 16:21 [PATCH 0/5] Additions to "save" command Tom Tromey
2023-01-29 16:21 ` [PATCH 1/5] Save breakpoints so they are automatically pending Tom Tromey
2023-01-31 15:14   ` Alexandra Petlanova Hajkova
2023-01-29 16:21 ` [PATCH 2/5] Move show_user_1 to cli-cmds.c Tom Tromey
2023-01-29 16:21 ` [PATCH 3/5] Add "save user" command Tom Tromey
2023-01-29 16:57   ` Eli Zaretskii
2023-01-30 14:53   ` Pedro Alves
2023-01-30 23:35     ` Tom Tromey
2023-01-29 16:21 ` [PATCH 4/5] Add "save skip" command Tom Tromey
2023-01-29 16:54   ` Eli Zaretskii [this message]
2023-01-29 16:21 ` [PATCH 5/5] Add "save history" command Tom Tromey
2023-01-29 16:56   ` Eli Zaretskii
2023-01-30 14:50   ` Pedro Alves
2023-01-30 15:12     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83cz6x703p.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).