From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 9397E3858D38 for ; Sun, 29 Jan 2023 16:54:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9397E3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMAwl-0000lX-H3; Sun, 29 Jan 2023 11:54:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jnrSglG5NE+9Rxsw35cJ0swNNnFwKmzxd4l20ERVCK0=; b=X3KPWdnJ66Xs xSZ42FUnSZnwucq4oXmCGGOjbnpuSsAnXFjCBHM6FCwKzl+6v1ihY21SND/e4zfIZyjJpOse/V9w3 gTA013WJNNb5t93CkrTjB3vjJhYGExqHsIspACC59JEl/aNd23fC5emSLObQ2kxkHJuKAgWYrYFy0 lsVk7E81hb/x0INZKuGmYZXTwR4gW16f+Ne9z7sJv1saPTc943ArdAgH7mI07MHbLloiZ8Lj+/xdJ H3EKUSIllNutza3Ze4L9edJS4OsOZ/lKMPQG0pMvwN2doCGUJduIWJJbXnwy74+UWWlznJDSla/tv RVtCjfYEMeHnN15zVguEIw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMAwk-00084a-Cu; Sun, 29 Jan 2023 11:54:27 -0500 Date: Sun, 29 Jan 2023 18:54:18 +0200 Message-Id: <83cz6x703p.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey Cc: gdb-patches@sourceware.org In-Reply-To: <20230129162105.526266-5-tom@tromey.com> (message from Tom Tromey on Sun, 29 Jan 2023 09:21:04 -0700) Subject: Re: [PATCH 4/5] Add "save skip" command References: <20230129162105.526266-1-tom@tromey.com> <20230129162105.526266-5-tom@tromey.com> X-Spam-Status: No, score=1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Tom Tromey > Cc: Tom Tromey > Date: Sun, 29 Jan 2023 09:21:04 -0700 > > PR cli/17997 points out that it would sometimes be convenient to save > the current "skip"s to a file. This patch implements this feature. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=17997 > --- > gdb/NEWS | 3 ++ > gdb/doc/gdb.texinfo | 6 +++ > gdb/skip.c | 78 +++++++++++++++++++++++++++++++++ > gdb/testsuite/gdb.base/skip.exp | 12 +++++ > 4 files changed, 99 insertions(+) Thanks, the documentation parts are okay, with one comment: > > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -6707,6 +6707,12 @@ Set whether to print the debug output about skipping files and functions. > @item show debug skip > Show whether the debug output about skipping files and functions is printed. > > +@kindex save skip > +@item save skip @var{filename} > +Save all skips to the file @var{filename}. This command writes out > +the skips as a script that can be re-read into @value{GDBN} using the > +@code{source} command. I wonder whether this new command should be described before "set/show debug skip"?