From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id C9B783858D3C for ; Sun, 16 Oct 2022 16:46:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C9B783858D3C Received: from fencepost.gnu.org ([2001:470:142:3::e]:49614) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ok6mO-0005qG-RM; Sun, 16 Oct 2022 12:46:24 -0400 Received: from [87.69.77.57] (port=4468 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ok6m6-0003fH-Rx; Sun, 16 Oct 2022 12:46:24 -0400 Date: Sun, 16 Oct 2022 19:45:46 +0300 Message-Id: <83czar4szp.fsf@gnu.org> From: Eli Zaretskii To: Andrei Pikas Cc: gdb-patches@sourceware.org, gdb@mail.api.win In-Reply-To: <20221016162809.32801-1-gdb@mail.api.win> (message from Andrei Pikas on Sun, 16 Oct 2022 19:28:09 +0300) Subject: Re: [PATCH v6] Add an option with a color type. References: <83edv74u1v.fsf@gnu.org> <20221016162809.32801-1-gdb@mail.api.win> X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2022 16:46:33 -0000 > From: Andrei Pikas > Cc: eliz@gnu.org, > Andrei Pikas > Date: Sun, 16 Oct 2022 19:28:09 +0300 > > Colors can be specified as "none" for terminal's default color, as a name of > one of the eight standard colors of ISO/IEC 6429 "black", "red", "green", etc., > as an RGB hexadecimal tripplet #RRGGBB for 24-bit TrueColor, or as an > integer from 0 to 255. Integers 0 to 7 are the synonyms for the standard > colors. Integers 8-15 are used for the so-called bright colors from the > aixterm extended 16-color palette. Integers 16-255 are the indexes into xterm > extended 256-color palette (usually 6x6x6 cube plus gray ramp). In > general, 256-color palette is terminal dependent and sometimes can be > changed with OSC 4 sequences, e.g. "\033]4;1;rgb:00/FF/00\033\\". > > It is the responsibility of the user to verify that the terminal supports > the specified colors. > > PATCH v5 changes: documentation fixed. > PATCH v6 changes: documentation fixed. > --- > gdb/Makefile.in | 2 + > gdb/NEWS | 29 ++ > gdb/cli/cli-cmds.c | 7 + > gdb/cli/cli-decode.c | 174 +++++++++ > gdb/cli/cli-decode.h | 21 + > gdb/cli/cli-option.c | 44 +++ > gdb/cli/cli-option.h | 21 + > gdb/cli/cli-setshow.c | 21 + > gdb/cli/cli-style.c | 49 +-- > gdb/cli/cli-style.h | 4 +- > gdb/command.h | 26 +- > gdb/doc/gdb.texinfo | 38 +- > gdb/doc/guile.texi | 104 +++++ > gdb/doc/python.texi | 97 +++++ > gdb/guile/guile-internal.h | 9 + > gdb/guile/guile.c | 1 + > gdb/guile/scm-color.c | 445 ++++++++++++++++++++++ > gdb/guile/scm-param.c | 29 +- > gdb/python/py-color.c | 346 +++++++++++++++++ > gdb/python/py-color.h | 35 ++ > gdb/python/py-param.c | 34 +- > gdb/python/python-internal.h | 2 + > gdb/python/python.c | 8 + > gdb/testsuite/gdb.base/style.exp | 209 +++++++++- > gdb/testsuite/gdb.guile/scm-color.exp | 114 ++++++ > gdb/testsuite/gdb.guile/scm-parameter.exp | 43 +++ > gdb/testsuite/gdb.python/py-color.exp | 101 +++++ > gdb/testsuite/gdb.python/py-parameter.exp | 53 +++ > gdb/testsuite/lib/gdb-utils.exp | 22 +- > gdb/top.c | 13 + > gdb/ui-style.c | 331 ++++++++++++---- > gdb/ui-style.h | 142 ++++++- > gdb/unittests/style-selftests.c | 6 +- > 33 files changed, 2420 insertions(+), 160 deletions(-) > create mode 100644 gdb/guile/scm-color.c > create mode 100644 gdb/python/py-color.c > create mode 100644 gdb/python/py-color.h > create mode 100644 gdb/testsuite/gdb.guile/scm-color.exp > create mode 100644 gdb/testsuite/gdb.python/py-color.exp OK for the documentation parts, thanks.