From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [209.51.188.92]) by sourceware.org (Postfix) with ESMTPS id C4B933857C50 for ; Thu, 31 Mar 2022 11:58:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C4B933857C50 Received: from [2001:470:142:3::e] (port=55696 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZtRy-00012k-9r; Thu, 31 Mar 2022 07:58:51 -0400 Received: from [87.69.77.57] (port=2862 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZtRs-0001px-EB; Thu, 31 Mar 2022 07:58:47 -0400 Date: Thu, 31 Mar 2022 14:58:54 +0300 Message-Id: <83czi272pt.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves Cc: brobecker@adacore.com, gdb-patches@sourceware.org In-Reply-To: <4f1b387d-8b63-47d6-79aa-93b27a2cdb9d@palves.net> (message from Pedro Alves on Thu, 31 Mar 2022 10:44:21 +0100) Subject: Re: GDB 12.0.90 available for testing References: <20220320055815.2A90FA4D6C@takamaka.home> <83sfr4a93r.fsf@gnu.org> <83o81m7icz.fsf@gnu.org> <4f1b387d-8b63-47d6-79aa-93b27a2cdb9d@palves.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=3.2 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Level: *** X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2022 11:58:53 -0000 > Date: Thu, 31 Mar 2022 10:44:21 +0100 > Cc: gdb-patches@sourceware.org > From: Pedro Alves > > On 2022-03-31 07:21, Eli Zaretskii via Gdb-patches wrote: > >> Date: Sat, 26 Mar 2022 20:59:04 +0300 > >> From: Eli Zaretskii via Gdb-patches > >> Cc: gdb-patches@sourceware.org > >> > >> Second, one of the selftests fails: > >> > >> Running selftest dw2_expand_symtabs_matching. > >> warning: charset conversion failure for 'u8fun├º├úo'. > >> You may have the wrong value for 'set ada source-charset'. > >> warning: could not convert 'yfunc ' from the host encoding (CP1255) to UTF-32. > >> This normally should not happen, please file a bug report. > >> > >> AFAIU, this is because the names of these two functions are, > >> respectively, in UTF-8 and in Latin-1, but the charset conversion > >> thinks they are in CP1255. Where does the test tell the conversion > >> functions what is the source encoding? > > > > Ping! Can someone please help me debugging this selftest failure? > > Where should I look for the definitions of the host charset used by > > this selftest? > > This is not really a failure, it's just a warning, though the message > gdb prints sounds scary. I chatted with Tromey about it last week, and the > issue is that there's a unit test that always exercises a symbol with a > latin-1 character (0xff). I added that testcase originally, and IIRC, that > was about making sure that the name lookup index was able to sort > strings properly with the 0xff character, because the code > does "ch+1" at some point in the sorting/lookup algorithm, which overflows > in that case. > > It may be that fix is to make the unit test temporarily set the > host charset, and also to remove that "should not happen" warning, as > I think that it should be possible to come up with such symbol names > with escape codes, thus it's not always really a bug. Does this test fail on GNU/Linux? If not, can you (or someone else) tell what is the difference between GNU/Linux and Windows for this purpose? Neither is using Latin-1 as the default host charset, right? > But in nutshell, this isn't really a GDB bug, and it shouldn't block the release. I didn't want to imply that the release should be blocked. I'm just trying to use the pretest for what i's intended: to find bugs and fix them, preferably before the release. TIA