From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [209.51.188.92]) by sourceware.org (Postfix) with ESMTPS id C3F873858002 for ; Thu, 9 Dec 2021 19:40:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C3F873858002 Received: from [2001:470:142:3::e] (port=55972 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvPHZ-000538-AB; Thu, 09 Dec 2021 14:40:45 -0500 Received: from [87.69.77.57] (port=3115 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvPHZ-0004mM-44; Thu, 09 Dec 2021 14:40:45 -0500 Date: Thu, 09 Dec 2021 21:40:29 +0200 Message-Id: <83czm5tvma.fsf@gnu.org> From: Eli Zaretskii To: Keith Seitz Cc: gdb-patches@sourceware.org In-Reply-To: <20211209191750.2601228-4-keiths@redhat.com> (message from Keith Seitz via Gdb-patches on Thu, 9 Dec 2021 11:17:50 -0800) Subject: Re: [PATCH v3 3/3] Support template lookups in strncmp_iw_with_mode References: <20211209191750.2601228-1-keiths@redhat.com> <20211209191750.2601228-4-keiths@redhat.com> X-Spam-Status: No, score=1.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Dec 2021 19:40:47 -0000 > Date: Thu, 9 Dec 2021 11:17:50 -0800 > From: Keith Seitz via Gdb-patches > > gdb/NEWS | 4 + > gdb/cp-support.c | 8 +- > gdb/doc/gdb.texinfo | 46 +++ > gdb/testsuite/gdb.cp/templates.cc | 47 +++ > gdb/testsuite/gdb.cp/templates.exp | 67 +++ > gdb/testsuite/gdb.linespec/cpcompletion.exp | 437 +++++++++++++++++++- > gdb/testsuite/gdb.linespec/cpls-ops.exp | 53 ++- > gdb/testsuite/gdb.linespec/cpls.cc | 110 ++++- > gdb/utils.c | 82 +++- > gdb/utils.h | 7 +- > 10 files changed, 821 insertions(+), 40 deletions(-) Thanks. I find the documentation of this feature hard to understand. I didn't understand what this does until I've read all of the new text, including the examples, twice. I think the documentation could be a lot more self-explanatory if the part about ignoring the template parameters were mentioned much earlier. > +* C++ developers may now ignore template parameter lists when specifying > + locations, e.g., while setting breakpoints. This is analogous to how > + completion and symbol lookup handle overloaded functions or ABI tags. This could be more clear if it described the GDB behavior, not what GDB users can do due to changes in the GDB behavior.