From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37349 invoked by alias); 19 Apr 2019 11:23:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37341 invoked by uid 89); 19 Apr 2019 11:23:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=wdyt, WDYT X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Apr 2019 11:23:49 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57614) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHRcP-0000jw-Ac; Fri, 19 Apr 2019 07:23:46 -0400 Received: from [176.228.60.248] (port=1184 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hHRcO-0004ic-Cg; Fri, 19 Apr 2019 07:23:45 -0400 Date: Fri, 19 Apr 2019 11:23:00 -0000 Message-Id: <83d0lick7o.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves CC: gdb-patches@sourceware.org In-reply-to: <556cefd7-47ce-54ab-a228-2c727aab4179@redhat.com> (message from Pedro Alves on Fri, 19 Apr 2019 11:51:46 +0100) Subject: Re: Fix compilation using mingw.org's MinGW References: <835zrbe36c.fsf@gnu.org> <250801eb-14f6-5a35-0556-cf5797dd8a7b@redhat.com> <83y347cfbu.fsf@gnu.org> <556cefd7-47ce-54ab-a228-2c727aab4179@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00372.txt.bz2 > Cc: gdb-patches@sourceware.org > From: Pedro Alves > Date: Fri, 19 Apr 2019 11:51:46 +0100 > > building at all either. The subject for the commit that added that NEWS entry > sound like that was the intention: > > commit 742a7df5f4a149f0818aaccfc432c4c0c9a6e26d > Author: Eli Zaretskii > AuthorDate: Sat Mar 2 15:18:32 2019 +0200 > > GDB no longer supports Windows before XP. > > But surprisingly, I can't find the discussion behind this commit > in the archives to see the context and what was decided. The discussion which led to that change is here: https://www.sourceware.org/ml/gdb-patches/2019-02/msg00574.html > >> So shouldn't we instead be setting _WIN32_WINNT to some > >> appropriate number? > > > > I don't mind, but where? > > I'd do it in common/common-defs.h, before any #include, where we define > other macros that must be defined before any include, like > __STDC_LIMIT_MACROS, _FORTIFY_SOURCE, etc. > > > And also: should we make such changes on the > > 8.3 branch at this time? > > Not sure. Off hand I'd think it's pretty safe, but maybe for 8.3 > your patch is safer. I will try doing this in common-defs.h, but for the branch, we could set _WIN32_WINNT only in windows-nat.c, as that's the only file that currently cares, which should be safer. WDYT?