From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21799 invoked by alias); 2 Jul 2010 10:09:06 -0000 Received: (qmail 21783 invoked by uid 22791); 2 Jul 2010 10:09:05 -0000 X-SWARE-Spam-Status: No, hits=0.0 required=5.0 tests=AWL,BAYES_40,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 Jul 2010 10:08:59 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0L4X00D00D7X8I00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 02 Jul 2010 13:03:02 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.229.12.240]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L4X008XND90I680@a-mtaout22.012.net.il>; Fri, 02 Jul 2010 13:03:01 +0300 (IDT) Date: Fri, 02 Jul 2010 10:09:00 -0000 From: Eli Zaretskii Subject: Re: Fix "maint time" command documentation. In-reply-to: To: "Anmol P. Paralkar" Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83d3v69p2j.fsf@gnu.org> References: X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00035.txt.bz2 > Date: Thu, 1 Jul 2010 18:20:49 -0500 (CDT) > From: "Anmol P. Paralkar" > > The documentation for the "maint time" command does not mention the units of time. > Also, there are a couple of typos in there. I have attempted to fix these in the > following patch; please let me know if we could word/punctuate this better and > I'll be happy to re-spin. Thanks. I have a few suggestions for a better change: > Control whether to display the execution time for each command. If > set to a nonzero value, @value{GDBN} will display how much time it > ! took (in seconds) to execute each command, following the command's own output. It would be better to place the units right after "time": Control whether to display the execution time for each command. If set to a nonzero value, @value{GDBN} will display how much time (in seconds) it took to execute each command, following the command's own output. > ! The time is not printed for the commands that run on the target, since > there's no mechanism currently to compute how much time was spend ^^^^^ "spent" > ! by @value{GDBN} and how much time was spend by the program been debugged; ^^^^^ ^^^^ "spent" and "being" > ! this is not possible currently. I think this part is not needed. The sentence already says that "there's no mechanism currently" to do this, so this addition simply reiterates the same thing. Thanks.