From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 8555F3858D28 for ; Thu, 19 Jan 2023 03:40:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8555F3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 30J3eNM7018323 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 18 Jan 2023 22:40:28 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 30J3eNM7018323 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1674099628; bh=Gl6fXMzwR3GVgHMdV40BwjpGhmeE2r5UIdkifnZ4Ul8=; h=Date:Subject:To:References:From:In-Reply-To:From; b=IboRhF/pjx+DnQn08//oCX3BmHF5EigcZIDQ7qqTjZVNKtKtnwEtjbJhvjGdIG1cX GJK6f61kKrUQz4uSh6an2vEP2YXXFXiz7RGlFuxrSqO7NGYrw5reeRNX06LaN2WJF4 v+VwI7H/Vj1pMXTSNdgBwQxQ4om3kd5xXjzGyEcE= Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 94EEC1E110; Wed, 18 Jan 2023 22:40:23 -0500 (EST) Message-ID: <83df6bcc-1843-2a5a-b8fd-8a17de141995@polymtl.ca> Date: Wed, 18 Jan 2023 22:40:22 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 00/13] Make frame_info_ptr automatic Content-Language: en-US To: Tom Tromey , Simon Marchi via Gdb-patches References: <20221214033441.499512-1-simon.marchi@polymtl.ca> <87h6wn1zo9.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87h6wn1zo9.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 19 Jan 2023 03:40:23 +0000 X-Spam-Status: No, score=-3032.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/18/23 13:10, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> This is v2 of: > Simon> https://inbox.sourceware.org/gdb-patches/20221202180052.212745-1-simon.marchi@polymtl.ca/ > > FWIW this seems good to me. It's definitely more robust in that it > eliminates this class of bug. > > Simon> The first main change is that I dropped the patch removing the user of > Simon> frame_info_ptr at many places, following Tom's comment. > > I don't think I intended for you to drop that, at least if we're talking > about this email: > > https://inbox.sourceware.org/gdb-patches/87cz8xjzp5.fsf@tromey.com/ > > If the current series works, though, then that seems fine as well. While replying to that email (this reply [1]), I actually became convinced that it would be fine and simpler to just use frame_info_ptr everywhere, so I did not do that change against my will. I will rebase and push, if everything still looks good after the rebase. Simon [1] https://inbox.sourceware.org/gdb-patches/b73e19be-165d-bcfb-3baf-9f56fcdc9537@polymtl.ca/