From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 17BF63858283 for ; Tue, 9 Jan 2024 16:33:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 17BF63858283 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 17BF63858283 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704818002; cv=none; b=bG3MXm6n5C56CArjb1WHZRXPjz4sR64mExl9d9Gshn5lVhI/qNqG75/j2yfQld2Qbbp/2lf9qiJkCM1u66sjfQ3ShKvJ9RQaRN4LWPbQr0d0GhGPVCCP+HOM+BCDD62GDHFVrSRfh/vu1Qball092z7ZWzfJfx4k6L0MWF40yW8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704818002; c=relaxed/simple; bh=8uXlNPLgL9bPAiOUner6zedpQtmr2IdTj7ZdF5rOABI=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=w/TvedBO+BD92euQ9NMONwB3TVcT1moz3Ng9A3EGDOgwnzDa5jGb2p9i38lgLZU23LjTwpYHXErt1/pzl1PpnDTye2HNvhipB3epa2fOHSjrj8rkPu07PGf4IR32qKMNN4oQ2YML+yDZRhaNDgKmF32wJxxUoIpj2N/11TL6wJw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNF2V-0000PP-7g; Tue, 09 Jan 2024 11:33:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JP4zN60Rdr1fDv3RJbpkVmADH5W2EtnOW3KY2sQl7os=; b=gN7/9Uc5k09e OOZptz0hkPXQehGuY22pz5vmKjtV1Km0O9rxexAu3IB67RRnWlKu/U9x9mfl7fKMbkvw7sO/pAbzS KR0xXl7iRJ2yfytKS7VebBpyVfhAaVaaYGqVtHZKzLAMXrlx2wvuvn2gBtCKDdkgUkM7eiK7MO5i2 kWbB3TEp5ENYHIKU1kNDHrCC67jl+lepeoAKzmWLp0jlUwupr5egfrQBl6i/VXFWHDs4jy62mg85n Q9o1f3VCvEnDonHT1pVRPxy1CYx8ZiQQAvz2AjNX19X1rjUxpNbosRhzDmTACsJDyD1kOCGFyfKyD M7CucPFju6OezjYtnYhU9g==; Date: Tue, 09 Jan 2024 18:32:58 +0200 Message-Id: <83edeqpiv9.fsf@gnu.org> From: Eli Zaretskii To: Andrew Burgess Cc: gdb-patches@sourceware.org, m.weghorn@posteo.de In-Reply-To: <4d76e490c2285dd7858b853f03465a1d798d6240.1704809585.git.aburgess@redhat.com> (message from Andrew Burgess on Tue, 9 Jan 2024 14:26:38 +0000) Subject: Re: [PATCH 15/16] gdb: new maintenance command to help debug remote argument issues References: <4d76e490c2285dd7858b853f03465a1d798d6240.1704809585.git.aburgess@redhat.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Andrew Burgess > Cc: Andrew Burgess , Michael Weghorn > Date: Tue, 9 Jan 2024 14:26:38 +0000 > > Add a new maintenance command 'maint test-remote-args', this command > takes an argument string and splits it using gdb::remote_args::split > and then joins the result using gdb::remote_args::join and prints all > of the results. This is useful for diagnosing problems with remote > argument passing. > > This new command is identical to what the remote argument self-tests > do, I found it easier to have a maintenance command available for > testing rather than having to add a new selftest and recompile GDB. > --- > gdb/NEWS | 4 ++ > gdb/doc/gdb.texinfo | 21 +++++++ > gdb/remote.c | 59 +++++++++++++++++++ > .../gdb.base/maint-test-remote-args.exp | 40 +++++++++++++ > 4 files changed, 124 insertions(+) > create mode 100644 gdb/testsuite/gdb.base/maint-test-remote-args.exp The documentation parts are okay, thanks. Reviewed-By: Eli Zaretskii