From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id D7B833858D37 for ; Thu, 30 Nov 2023 19:31:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D7B833858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D7B833858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701372684; cv=none; b=n0Fs88KMFUNJtSUL8L0Eki1HCoGLSW8n9VGiciNsiXhwUy+wiLgmfvNP48Dq3gUjsxzk4bZl/WImQqV6d7mjndwZ8686dgPyzveVAdzy/lBfz1n39bI6v7zhFyxlGheBGn254eQ2QGm3/Ku0K7DyqPnN9cCFjhuHS/mDhzniGtA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701372684; c=relaxed/simple; bh=pE2SOAzrarePfO6QuJGON1FSWujZZffh5X5UdFa6Lvc=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=vol8mlH5LLqapTW+8nollOtsC6ktINwgQ/NPDIhoigutWwjuT7kmidzpIQRi6bTpr92b/JrKz2RCQlvFq3x7nKvtkCqs6AQXv8Gqc7KATekaFXWWiqt0BCSKUq4ab0mKfdAu4N/6idQUkJWKpIJZsh3Vy/fdx/jU4FycYx8AeW8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8mkk-0004WY-SQ; Thu, 30 Nov 2023 14:31:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=hsbhW1YPmkFUGjUbvKPhGuBI6ctMAAuP1m3TRYhonf8=; b=o8KU+JvOXuWx yt5BHD2KIGJCEMJX82ZmaLojdoLlJGvVpPMEl+OW+nzO7TZNkZfbNSY1KnKUzkMiBOoAps1coqQcf BfpDqn5qZAbte0Cpjsacorve7ILgIha/RqJvBKCWg0ycNrsm83VR+GvBXpAWkh85kNS8tU2ievFRz gohTn2SnwsBd5uO8MtPms3hEJglJpsT8j6aeFrLUwkoodUVDX7ARXN/tJn2fteSi7QFEcs2Gv6Auo Qcle9Mk+yeFm8bEJrmatRxSqnkibCVd2/PLpgEWWpGiApjvQgSSRXeqni5vdSHoq65RHFSIdCefOR giBEXt1ycoU4FddEf637yw==; Date: Thu, 30 Nov 2023 21:30:20 +0200 Message-Id: <83edg7avjn.fsf@gnu.org> From: Eli Zaretskii To: Andrew Burgess Cc: gdb-patches@sourceware.org In-Reply-To: <6b7bbefbcee3e19a87c46f7bc13e453ec10509a4.1701369189.git.aburgess@redhat.com> (message from Andrew Burgess on Thu, 30 Nov 2023 18:44:18 +0000) Subject: Re: [PATCHv2 3/3] gdbserver: allow for general 'monitor set debug COMPONENT VALUE' use References: <6b7bbefbcee3e19a87c46f7bc13e453ec10509a4.1701369189.git.aburgess@redhat.com> X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Andrew Burgess > Cc: Andrew Burgess > Date: Thu, 30 Nov 2023 18:44:18 +0000 > > gdb/NEWS | 8 ++ > gdb/doc/gdb.texinfo | 30 +++-- > gdb/testsuite/gdb.server/server-mon.exp | 25 +++- > gdbserver/server.cc | 159 +++++++++++++++++++----- > 4 files changed, 179 insertions(+), 43 deletions(-) Thanks. > diff --git a/gdb/NEWS b/gdb/NEWS > index 94d1fd8ea8d..c8166f08218 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -48,6 +48,14 @@ show remote thread-options-packet > supported components are: all, threads, event-loop, and remote. > If no components are given then threads is assumed. > > + ** The 'monitor set remote-debug' and 'monitor set event-loop-debug' > + command have been removed. > + > + ** The 'monitor set debug 0|1' command has been extended to take a > + component name, e.g.: 'monitor set debug COMPONENT off|on'. > + Possible component names are: all, threads, event-loop, and > + remote. > + > * Python API This part is OK. > +@item monitor set debug threads off > +@itemx monitor set debug threads on > +Disable or enable specific logging messages associated thread handling ^ "with" is missing there. Reviewed-By: Eli Zaretskii