From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 6ED573858C1F for ; Mon, 14 Aug 2023 12:14:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6ED573858C1F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVWSa-0006mD-0K; Mon, 14 Aug 2023 08:14:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GMJODooyMLv3zRniciuWitOF8TQUzYOCyBFQ7apfd8s=; b=Z6Wy1qyVC43/ lDlhfm6Q7ZR4RH8BucSR9cH8Zn3GcTYFAn5c7f3S5Bff4eNr2uNBNCk3FlHn3eh0xrtkGMe6a9G8Z 8XTrfrPGWJFZZ41sJvqBi58ppftv/5YZEoWX6/+0NiVs0680HwsiV5eIk6PLofLqUWdkrvLuKMmju sBGqdDiLhc/C2kYunWqvwIWejBDp8i8RwrQHLQldL/lZwOJRDY/gYmCbr99XZkxIIDKrQgfgyh8fR hv2Ys3p/2b3nie/sXDjhcMs2fzOXx6PYHCAySXEnNLJW+Kk31dQSiuEvPvBStSBE4MeJh+00WcopY ya3leuizhzxygl0+f5ERuQ==; Date: Mon, 14 Aug 2023 15:14:12 +0300 Message-Id: <83edk5bz3f.fsf@gnu.org> From: Eli Zaretskii To: Tom de Vries Cc: gdb-patches@sourceware.org In-Reply-To: <20230814085340.4066-1-tdevries@suse.de> (message from Tom de Vries via Gdb-patches on Mon, 14 Aug 2023 10:53:40 +0200) Subject: Re: [PATCH] [gdb] Fix maint print symbols/psymbols help text References: <20230814085340.4066-1-tdevries@suse.de> X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Date: Mon, 14 Aug 2023 10:53:40 +0200 > From: Tom de Vries via Gdb-patches > > diff --git a/gdb/psymtab.c b/gdb/psymtab.c > index 64b67078641..bdae9db9676 100644 > --- a/gdb/psymtab.c > +++ b/gdb/psymtab.c > @@ -1687,7 +1687,7 @@ Entries in the partial symbol table are dumped to file OUTFILE,\n\ > or the terminal if OUTFILE is unspecified.\n\ > If ADDRESS is provided, dump only the file for that address.\n\ > If SOURCE is provided, dump only that file's symbols.\n\ > -If OBJFILE is provided, dump only that file's minimal symbols."), > +If OBJFILE is provided, dump only that object file's symbols."), > &maintenanceprintlist); > > add_cmd ("psymtabs", class_maintenance, maintenance_info_psymtabs, _("\ > diff --git a/gdb/symmisc.c b/gdb/symmisc.c > index a65552aa2d2..5b8a82e5137 100644 > --- a/gdb/symmisc.c > +++ b/gdb/symmisc.c > @@ -1052,7 +1052,7 @@ Entries in the full symbol table are dumped to file OUTFILE,\n\ > or the terminal if OUTFILE is unspecified.\n\ > If ADDRESS is provided, dump only the file for that address.\n\ > If SOURCE is provided, dump only that file's symbols.\n\ > -If OBJFILE is provided, dump only that file's minimal symbols."), > +If OBJFILE is provided, dump only that object file's symbols."), > &maintenanceprintlist); > > add_cmd ("msymbols", class_maintenance, maintenance_print_msymbols, _("\ Thanks, this LGTM, but shouldn't the "ADDRESS" line be reworded like below? If ADDRESS is provided, dump only the symbols for that address. If that's not the intent, then can someone please explain the meaning of "the file for that address"?