From: Eli Zaretskii <eliz@gnu.org>
To: "Willgerodt, Felix" <felix.willgerodt@intel.com>
Cc: gdb-patches@sourceware.org, markus.t.metzger@intel.com, simark@simark.ca
Subject: Re: [PATCH v9 05/10] python: Introduce gdb.RecordAuxiliary class.
Date: Wed, 05 Jul 2023 14:37:06 +0300 [thread overview]
Message-ID: <83edlmk2sd.fsf@gnu.org> (raw)
In-Reply-To: <MN2PR11MB456647F49D54B5A16F77D02C8E2FA@MN2PR11MB4566.namprd11.prod.outlook.com> (felix.willgerodt@intel.com)
> From: "Willgerodt, Felix" <felix.willgerodt@intel.com>
> CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, "Metzger,
> Markus T" <markus.t.metzger@intel.com>, "simark@simark.ca" <simark@simark.ca>
> Date: Wed, 5 Jul 2023 10:04:53 +0000
>
> > I think "number" should be in @var, like this:
> >
> > +@defvar RecordAuxiliary.@var{number}
> > +An integer identifying this auxiliary. @var{number} corresponds to the
> > numbers
> > +seen in @code{record instruction-history} (@pxref{Process Record and
> > Replay}).
> >
> > because "number" is not a literal string, it stands for some numerical
> > string. Right?
>
> I just copied it from the RecordGap.number text to be honest, there it is
> also in a @code. It is supposed to be the actual python member.
> It is both code and a variable ;)
> The surrounding test seems to favour code. I am happy to change it to
> whatever you think is right. I see both equally possible.
Yes, @var is the right markup here.
next prev parent reply other threads:[~2023-07-05 11:37 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 12:35 [PATCH v9 00/10] Extensions for PTWRITE Felix Willgerodt
2023-07-04 12:35 ` [PATCH v9 01/10] btrace: Introduce auxiliary instructions Felix Willgerodt
2023-07-04 12:44 ` Eli Zaretskii
2023-07-04 12:35 ` [PATCH v9 02/10] btrace: Enable auxiliary instructions in record instruction-history Felix Willgerodt
2023-07-04 12:45 ` Eli Zaretskii
2023-07-04 12:35 ` [PATCH v9 03/10] btrace: Enable auxiliary instructions in record function-call-history Felix Willgerodt
2023-07-04 12:47 ` Eli Zaretskii
2023-07-04 12:35 ` [PATCH v9 04/10] btrace: Handle stepping and goto for auxiliary instructions Felix Willgerodt
2023-07-04 12:35 ` [PATCH v9 05/10] python: Introduce gdb.RecordAuxiliary class Felix Willgerodt
2023-07-04 12:52 ` Eli Zaretskii
2023-07-05 10:04 ` Willgerodt, Felix
2023-07-05 11:37 ` Eli Zaretskii [this message]
2023-07-04 12:35 ` [PATCH v9 06/10] python: Add clear() to gdb.Record Felix Willgerodt
2023-07-04 12:46 ` Eli Zaretskii
2023-07-05 10:03 ` Willgerodt, Felix
2023-07-05 11:35 ` Eli Zaretskii
2023-07-06 16:11 ` Tom Tromey
2023-07-13 12:34 ` Willgerodt, Felix
2023-07-13 16:45 ` Tom Tromey
2023-07-14 11:07 ` Willgerodt, Felix
2023-07-04 12:35 ` [PATCH v9 07/10] btrace, gdbserver: Add ptwrite to btrace_config_pt Felix Willgerodt
2023-07-04 12:49 ` Eli Zaretskii
2023-07-05 10:04 ` Willgerodt, Felix
2023-07-04 12:35 ` [PATCH v9 08/10] btrace, linux: Enable ptwrite packets Felix Willgerodt
2023-07-04 12:35 ` [PATCH v9 09/10] btrace, python: Enable ptwrite filter registration Felix Willgerodt
2023-07-06 16:31 ` Tom Tromey
2023-07-13 12:34 ` Willgerodt, Felix
2023-07-04 12:36 ` [PATCH v9 10/10] btrace: Extend ptwrite event decoding Felix Willgerodt
2023-07-04 12:56 ` Eli Zaretskii
2023-07-05 10:04 ` Willgerodt, Felix
2023-07-06 16:46 ` Tom Tromey
2023-07-13 12:34 ` Willgerodt, Felix
2023-07-06 16:37 ` [PATCH v9 00/10] Extensions for PTWRITE Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83edlmk2sd.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=felix.willgerodt@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).