Re: [PATCH v9 10/10] btrace: Extend ptwrite event decoding.

[Eli Zaretskii <eliz@gnu.org>]

> Cc: Felix Willgerodt <felix.willgerodt@intel.com>
> Date: Tue,  4 Jul 2023 14:36:00 +0200
> From: Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
> 
> Call the ptwrite filter function whenever a ptwrite event is decoded.
> The returned string is written to the aux_data string table and a
> corresponding auxiliary instruction is appended to the function segment.
> ---
>  gdb/NEWS                                  |   7 +
>  gdb/btrace.c                              |  58 +++
>  gdb/config.in                             |   3 +
>  gdb/configure                             |  11 +
>  gdb/doc/python.texi                       | 148 ++++++
>  gdb/testsuite/gdb.btrace/i386-ptwrite.S   | 550 ++++++++++++++++++++++
>  gdb/testsuite/gdb.btrace/ptwrite.c        |  39 ++
>  gdb/testsuite/gdb.btrace/ptwrite.exp      | 202 ++++++++
>  gdb/testsuite/gdb.btrace/x86_64-ptwrite.S | 544 +++++++++++++++++++++
>  gdb/testsuite/lib/gdb.exp                 |  72 +++
>  gdbsupport/common.m4                      |   2 +
>  gdbsupport/config.in                      |   3 +
>  gdbsupport/configure                      |  11 +
>  13 files changed, 1650 insertions(+)
>  create mode 100644 gdb/testsuite/gdb.btrace/i386-ptwrite.S
>  create mode 100644 gdb/testsuite/gdb.btrace/ptwrite.c
>  create mode 100644 gdb/testsuite/gdb.btrace/ptwrite.exp
>  create mode 100644 gdb/testsuite/gdb.btrace/x86_64-ptwrite.S

Thanks, the documentation parts are OK, with this one nit:

> +The @code{gdb.ptwrite} module allows customizing the default output of
> +@code{PTWRITE} auxiliary information.  A custom Python function can be
> +registered as the @code{PTWRITE} filter function.  This function will be
> +called with the @code{PTWRITE} payload and PC as arguments during trace
> +decoding.  It can return a string, which will be printed by @value{GDBN}
> +during the aforementioned commands, or @code{None}, resulting in no output.
> +To register such a filter function, the user needs to provide a filter factory
> +function, which returns a new filter function object to be called by GDB.
                                                                        ^^^
"@value{GDBN}"

Reviewed-By: Eli Zaretskii <eliz@gnu.org>