From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 2799F3858D3C
 for <gdb-patches@sourceware.org>; Sun, 16 Oct 2022 16:23:09 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2799F3858D3C
Received: from fencepost.gnu.org ([2001:470:142:3::e]:45722)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1ok6Ps-0002HF-C1; Sun, 16 Oct 2022 12:23:08 -0400
Received: from [87.69.77.57] (port=3055 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1ok6Pq-0004D2-9K; Sun, 16 Oct 2022 12:23:06 -0400
Date: Sun, 16 Oct 2022 19:22:52 +0300
Message-Id: <83edv74u1v.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Andrei Pikas <gdb@mail.api.win>
Cc: gdb-patches@sourceware.org, gdb@mail.api.win
In-Reply-To: <20221016160354.30740-1-gdb@mail.api.win> (message from Andrei
 Pikas on Sun, 16 Oct 2022 19:03:54 +0300)
Subject: Re: [PATCH v5] Add an option with a color type.
References: <83mt9v51c5.fsf@gnu.org> <20221016160354.30740-1-gdb@mail.api.win>
X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Oct 2022 16:23:10 -0000

> From: Andrei Pikas <gdb@mail.api.win>
> Cc: eliz@gnu.org,
> 	Andrei Pikas <gdb@mail.api.win>
> Date: Sun, 16 Oct 2022 19:03:54 +0300
> 
> +@deffn {Scheme Procedure} color-escape-sequence color is_foreground
> +Return string to change terminal's color to this.
> +
> +@var{is_foreground} If @var{is_foreground} is @code{#t}, then the returned
   ^^^^^^^^^^^^^^^^^^^^
I believe the underlined part should be deleted.

> +sequence will change foreground color. Otherwise, the returned sequence will
                                        ^^
Two spaces between sentences, please.

> +@defun Color.escape_sequence (@var{self}, @var{is_foreground})
> +Returns string to change terminal's color to this.
> +
> +@var{is_foreground} If @var{is_foreground} is @code{True}, then the returned
> +sequence will change foreground color. Otherwise, the returned sequence will
> +change background color.
> +@end defun

Same here.

The documentation parts are okay when these nits are fixed.

Thanks.