From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 282D5385AC20
 for <gdb-patches@sourceware.org>; Mon, 22 Aug 2022 02:26:22 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 282D5385AC20
Received: from fencepost.gnu.org ([2001:470:142:3::e]:37908)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1oPx8v-0000ZM-1j; Sun, 21 Aug 2022 22:26:21 -0400
Received: from [87.69.77.57] (port=1223 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1oPx8u-0004wo-MF; Sun, 21 Aug 2022 22:26:20 -0400
Date: Mon, 22 Aug 2022 05:26:22 +0300
Message-Id: <83edx9au9d.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Andrei Pikas <gdb@mail.api.win>
Cc: gdb-patches@sourceware.org
In-Reply-To: <5c28f4cb-3ca6-6a3e-41b3-1fcc5d0afbfc@mail.api.win> (message from
 Andrei Pikas on Sun, 21 Aug 2022 23:09:16 +0300)
Subject: Re: [PATCH v2] Add an option with a color type.
References: <87zgg2ydhx.fsf@redhat.com>
 <20220820121917.11438-1-gdb@mail.api.win> <835yindr0c.fsf@gnu.org>
 <5c28f4cb-3ca6-6a3e-41b3-1fcc5d0afbfc@mail.api.win>
X-Spam-Status: No, score=1.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Aug 2022 02:26:23 -0000

> Date: Sun, 21 Aug 2022 23:09:16 +0300
> Cc: gdb-patches@sourceware.org
> From: Andrei Pikas <gdb@mail.api.win>
> 
>  > how do we check that TrueColor is
>  > supported by the terminal, and what will happen if they aren't?
> 
> We don't check that TrueColor is supported by the terminal, because we 
> don't use TrueColor by default. Thus, the user is responsible for 
> setting the colors supported by his terminal.

This responsibility of the user should at least be documented.
Probably together with some practical advice how to check that.

Also, IMO we should make sure no catastrophe happens if the user
decides incorrectly, and the result will be limited to somewhat messy
display, nothing worse.

Thanks.