Re: [PATCHv3 4/6] gdb/python: implement the print_insn extension language hook

[Eli Zaretskii <eliz@gnu.org>]

> Date: Mon,  4 Apr 2022 23:19:57 +0100
> From: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Andrew Burgess <andrew.burgess@embecosm.com>
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -18,6 +18,40 @@
>       This is the same format that GDB uses when printing address, symbol,
>       and offset information from the disassembler.
>  
> +  ** New Python API for wrapping GDB's disassembler:
> +
> +     - gdb.disassembler.register_disassembler(DISASSEMBLER, ARCH).
> +       DISASSEMBLER is a sub-class of gdb.disassembler.Disassembler.
> +       ARCH is either None or a string containing a bfd architecture
> +       name.  DISASSEMBLER is registered as a disassembler for
> +       architecture ARCH, or for all architectures if ARCH is None.
> +       The previous disassembler registered for ARCH is returned, this
> +       can be None if no previous disassembler was registered.
> +
> +     - gdb.disassembler.Disassembler is the class from which all
> +       disassemblers should inherit.  Its constructor takes a string,
> +       a name for the disassembler, which is currently only used is
> +       some debug output.                                        ^^

A typo. 

> +Or, this function can return an object that represents the
   ^^^^^^^^^^^^^^^^^
It is better to say "Alternatively, this function ..."

> +The required properties, which this class provides are:
                                                     ^
A comma is missing there.

> +@cindex disassembler in Python, global vs.@: specific
> +@cindex search order for disassembler in Python
> +@cindex look up of disassembler in Python
> +
> +@value{GDBN} only records a single disassembler for each architecture,

There shouldn't be an empty line between the @cindex entries and the
following text, so that the position recorded in the index is the
beginning of the text, not a newline away.

The documentation parts are approved, once those nits are fixed.

Thanks.