From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [209.51.188.92])
 by sourceware.org (Postfix) with ESMTPS id 62DD03858C83
 for <gdb-patches@sourceware.org>; Tue,  8 Mar 2022 12:16:44 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 62DD03858C83
Received: from [2001:470:142:3::e] (port=36962 helo=fencepost.gnu.org)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nRYlf-0005Od-GU; Tue, 08 Mar 2022 07:16:43 -0500
Received: from [87.69.77.57] (port=3604 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nRYle-0002bF-TA; Tue, 08 Mar 2022 07:16:43 -0500
Date: Tue, 08 Mar 2022 14:16:36 +0200
Message-Id: <83ee3cfxln.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <de69e7d915c5123008e188d73462007a24c7b002.1646691034.git.aburgess@redhat.com>
 (message from Andrew Burgess via Gdb-patches on Mon, 7 Mar 2022
 22:13:38 +0000)
Subject: Re: [PATCHv3 06/15] gdb/tui: add a tui debugging flag
References: <cover.1644156219.git.aburgess@redhat.com>
 <cover.1646691034.git.aburgess@redhat.com>
 <de69e7d915c5123008e188d73462007a24c7b002.1646691034.git.aburgess@redhat.com>
X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Mar 2022 12:16:45 -0000

> Date: Mon,  7 Mar 2022 22:13:38 +0000
> From: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Andrew Burgess <aburgess@redhat.com>
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 1275d967a2d..eb18ac47804 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -133,6 +133,10 @@ winwidth
>    the width of a tui window to be adjusted when windows are laid out
>    in horizontal mode.
>  
> +set debug tui on|off
> +show debug tui
> +  Control the display of debug output about GDB's tui.
> +
>  * Changed commands
>  
>  maint packet
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 6081aa85af4..60173e07747 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -29205,6 +29205,17 @@
>  source text at the next tab stop; the compact display uses only as
>  much space as is needed for the line numbers in the current file, and
>  only a single space to separate the line numbers from the source.
> +
> +@kindex set debug tui
> +@item set debug tui @r{[}on|off@r{]}
> +Turn on or off display of @value{GDBN} internal debug messages relating
> +to the TUI.
> +
> +@kindex show debug tui
> +@item show debug tui
> +Show the current status of displaying @value{GDBN} internal debug
> +messages relating to the TUI.
> +

The documentation parts are OK, but I wonder whether we should mention
the caveats you described, at least in NEWS.  I'm aware that we don't
usually describe known bugs, but since you say this could cause
crashes, perhaps it justifies an exception?

Thanks.