From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121554 invoked by alias); 23 Nov 2019 07:24:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 121541 invoked by uid 89); 23 Nov 2019 07:24:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1152 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 23 Nov 2019 07:24:27 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56070) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iYPmI-0000kd-By; Sat, 23 Nov 2019 02:24:23 -0500 Received: from [176.228.60.248] (port=2548 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iYPmF-00033U-9n; Sat, 23 Nov 2019 02:24:20 -0500 Date: Sat, 23 Nov 2019 07:24:00 -0000 Message-Id: <83eexzukbj.fsf@gnu.org> From: Eli Zaretskii To: tromey@sourceware.org, gdb-patches@sourceware.org In-reply-to: <20191122235414.9AB352816F@gnutoolchain-gerrit.osci.io> Subject: Re: [review v2] Add TUI border colors References: <20191122235414.9AB352816F@gnutoolchain-gerrit.osci.io> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-11/txt/msg00787.txt.bz2 > Date: Fri, 22 Nov 2019 18:54:13 -0500 > From: "Tom Tromey (Code Review)" > > +@item tui-border > +Control the styling of the TUI border. Note that, unlike other > +styling options, only the color of the border can be controlled via > +@code{set style}. This was done for compatibility reasons, as TUI > +controls to set the border's intensity predated the addition of > +general styling to @value{GDBN}. @xref{TUI Configuration}. > + > +@item tui-active-border > +Control the styling of the active TUI border; that is, the TUI window > +that has the focus. Note that, unlike other styling options, only the > +color of the border can be controlled via @code{set style}. This was > +done for compatibility reasons, as TUI controls to set the active > +border's intensity predated the addition of general styling to > +@value{GDBN}. @xref{TUI Configuration}. I wonder if we could say the "Note" part only once, for both tui-border and tui-active-border. It sounds redundant to repeat the same text so close to one another. Otherwise, the documentation parts are OK. Thanks.