From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111536 invoked by alias); 10 Aug 2018 07:32:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111527 invoked by uid 89); 10 Aug 2018 07:32:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=WHICH, H*r:sk:RSA_AES X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Aug 2018 07:32:16 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fo1u9-0001g4-6N for gdb-patches@sourceware.org; Fri, 10 Aug 2018 03:32:14 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56495) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fo1u0-0001Zq-UB; Fri, 10 Aug 2018 03:32:05 -0400 Received: from [176.228.60.248] (port=2176 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fo1u0-00022K-A3; Fri, 10 Aug 2018 03:32:04 -0400 Date: Fri, 10 Aug 2018 07:32:00 -0000 Message-Id: <83eff6oex7.fsf@gnu.org> From: Eli Zaretskii To: Pedro Franco de Carvalho CC: gdb-patches@sourceware.org, uweigand@de.ibm.com, edjunior@gmail.com In-reply-to: <20180810025210.6942-10-pedromfc@linux.ibm.com> (message from Pedro Franco de Carvalho on Thu, 9 Aug 2018 23:52:07 -0300) Subject: Re: [PATCH v2 09/12] [PowerPC] Add support for TAR References: <20180810025210.6942-1-pedromfc@linux.ibm.com> <20180810025210.6942-10-pedromfc@linux.ibm.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00258.txt.bz2 > From: Pedro Franco de Carvalho > Cc: uweigand@de.ibm.com, edjunior@gmail.com > Date: Thu, 9 Aug 2018 23:52:07 -0300 > > From: Edjunior Barbosa Machado > > This patch adds support for the Target Address Register for powerpc > linux native and core file targets, and in the powerpc linux server > stub. > > gdb/ChangeLog: > YYYY-MM-DD Edjunior Barbosa Machado > Pedro Franco de Carvalho > > * arch/ppc-linux-tdesc.h (tdesc_powerpc_isa207_vsx32l) > (tdesc_powerpc_isa207_vsx64l): Declare. > * arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_TARREGSET): Define. > (struct ppc_linux_features) : New field. > (ppc_linux_no_features): Add initializer for isa207 field. > * arch/ppc-linux-common.c (ppc_linux_match_description): Return > new tdescs. > * nat/ppc-linux.h (PPC_FEATURE2_ARCH_2_07, PPC_FEATURE2_TAR) > (NT_PPC_TAR): Define if not already defined. > * features/Makefile (WHICH): Add rs6000/powerpc-isa207-vsx32l and > rs6000/powerpc-isa207-vsx64l. > (XMLTOC): Add rs6000/powerpc-isa207-vsx32l.xml and > rs6000/powerpc-isa207-vsx64l.xml. > * features/rs6000/power-tar.xml: New file. > * features/rs6000/powerpc-isa207-vsx32l.xml: New file. > * features/rs6000/powerpc-isa207-vsx64l.xml: New file. > * features/rs6000/powerpc-isa207-vsx32l.c: Generate. > * features/rs6000/powerpc-isa207-vsx64l.c: Generate. > * regformats/rs6000/powerpc-isa207-vsx32l.dat: Generate. > * regformats/rs6000/powerpc-isa207-vsx64l.dat: Generate. > * ppc-linux-nat.c (fetch_register, fetch_ppc_registers): Call > fetch_regset with the TAR regset. > (store_register, store_ppc_registers): Call store_regset with the > TAR regset. > (ppc_linux_nat_target::read_description): Set isa207 field in the > features struct if needed. > * ppc-linux-tdep.c: Include > features/rs6000/powerpc-isa207-vsx32l.c and > features/rs6000/powerpc-isa207-vsx64l.c. > (ppc32_regmap_tar, ppc32_linux_tarregset): New globals. > (ppc_linux_iterate_over_regset_sections): Call back with the tar > regset. > (ppc_linux_core_read_description): Check if the tar section is > present and set isa207 in the features struct. > (_initialize_ppc_linux_tdep): Call > initialize_tdesc_powerpc_isa207_vsx32l and > initialize_tdesc_powerpc_isa207_vsx64l. > * ppc-linux-tdep.h (ppc32_linux_tarregset): Declare. > * ppc-tdep.h (gdbarch_tdep) : New field. > (enum) : New enum value. > * rs6000-tdep.c (rs6000_gdbarch_init): Look for and validate tar > feature. > (ppc_process_record_op31): Record changes to TAR. > > gdb/gdbserver/ChangeLog: > YYYY-MM-DD Pedro Franco de Carvalho > > * configure.srv (ipa_ppc_linux_regobj): Add > powerpc-isa207-vsx64l-ipa.o and powerpc-isa207-vsx32l-ipa.o. > (powerpc*-*-linux*): Add powerpc-isa207-vsx32l.o and > powerpc-isa207-vsx64l.o to srv_regobj, add rs6000/power-tar.xml, > rs6000/powerpc-isa207-vsx32l.xml, and > rs6000/powerpc-isa207-vsx64l.xml to srv_xmlfiles. > * linux-ppc-tdesc-init.h (enum ppc_linux_tdesc) > : New enum value. > (init_registers_powerpc_isa207_vsx32l): Declare. > (init_registers_powerpc_isa207_vsx64l): Declare. > * linux-ppc-low.c (ppc_fill_tarregset): New function. > (ppc_store_tarregset): New function. > (ppc_regsets): Add entry for the TAR regset. > (ppc_arch_setup): Set isa207 in features struct when needed. Set > size for the TAR regsets. > (ppc_get_ipa_tdesc_idx): Return PPC_TDESC_ISA207_VSX. > (initialize_low_arch): Call init_registers_powerpc_isa207_vsx32l > and init_registers_powerpc_isa207_vsx64l. > * linux-ppc-ipa.c (get_ipa_tdesc): Handle PPC_TDESC_ISA207_VSX. > (initialize_low_tracepoint): Call > init_registers_powerpc_isa207_vsx32l and > init_registers_powerpc_isa207_vsx64l. > > gdb/testsuite/ChangeLog: > YYYY-MM-DD Pedro Franco de Carvalho > > * gdb.arch/powerpc-tar.c: New file. > * gdb.arch/powerpc-tar.exp: New file. > > gdb/doc/ChangeLog: > YYYY-MM-DD Pedro Franco de Carvalho > > * gdb.texinfo (PowerPC Features): Describe new feature > "org.gnu.gdb.power.tar". OK for the gdb.texinfo part. Thanks.