From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67952 invoked by alias); 4 Jul 2018 16:44:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67939 invoked by uid 89); 4 Jul 2018 16:44:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=locals, Acquisition, HTo:D*be, HContent-Transfer-Encoding:8bit X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Jul 2018 16:44:42 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1faktQ-0005es-HE for gdb-patches@sourceware.org; Wed, 04 Jul 2018 12:44:39 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41335) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1faktQ-0005em-Dc; Wed, 04 Jul 2018 12:44:36 -0400 Received: from [176.228.60.248] (port=4810 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1faktP-00043K-PY; Wed, 04 Jul 2018 12:44:36 -0400 Date: Wed, 04 Jul 2018 16:44:00 -0000 Message-Id: <83efgjne6l.fsf@gnu.org> From: Eli Zaretskii To: Philippe Waroquiers CC: gdb-patches@sourceware.org In-reply-to: <1530564328.29413.8.camel@skynet.be> (message from Philippe Waroquiers on Mon, 02 Jul 2018 22:45:28 +0200) Subject: Re: [RFC 4/5] Document changes to info [args|functions|locals|variables] References: <20180701210734.3793-1-philippe.waroquiers@skynet.be> <20180701210734.3793-5-philippe.waroquiers@skynet.be> <8336x1llzk.fsf@gnu.org> <1530564328.29413.8.camel@skynet.be> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00109.txt.bz2 > From: Philippe Waroquiers > Cc: gdb-patches@sourceware.org > Date: Mon, 02 Jul 2018 22:45:28 +0200 > > If both @var{regexp} and @var{type_regexp} are provided, a local variable > is printed only if it respects the two regexps. I'd use "matches", not "respects". > The command @kbd{info locals -q -t @var{type_regexp}} can usefully be > combined with the commands @kbd{frame apply} and @kbd{thread apply}. > For example, your program might use Resource Acquisition Is > Initialization types (RAII) such as @code{lock_something_t} : each > local variable of type @code{lock_something_t} automatically places a > lock that is destroyed when the variable goes out of scope.  You can > then list all acquired locks in your program by doing > @smallexample > thread apply all -s frame apply all -s info locals -q -t lock_something_t > @end smallexample > or the equivalent shorter form You want @noindent on a separate line before the "or the equivalent", otherwise the printed manual will have that indented as if it were a new paragraph (which it isn't). > I have tried to explain RAII in the doc above, but wondering if that > is clear enough. I think it's enough, they can google it if they want to know more. Thanks, I have no more comments to the new text except the above few nits.