From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31778 invoked by alias); 15 Jan 2014 16:57:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31759 invoked by uid 89); 15 Jan 2014 16:57:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mtaout26.012.net.il Received: from mtaout26.012.net.il (HELO mtaout26.012.net.il) (80.179.55.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 15 Jan 2014 16:57:52 +0000 Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0MZG00A00C2I6300@mtaout26.012.net.il>; Wed, 15 Jan 2014 18:57:29 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MZG00849CFT3W40@mtaout26.012.net.il>; Wed, 15 Jan 2014 18:57:29 +0200 (IST) Date: Wed, 15 Jan 2014 16:57:00 -0000 From: Eli Zaretskii Subject: Re: small request regarding commits in binutils-gdb.git In-reply-to: <20140115162518.GL4762@adacore.com> To: Joel Brobecker Cc: binutils@sourceware.org, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83eh4941yu.fsf@gnu.org> References: <20140115121251.GM4639@adacore.com> <83mwix44gh.fsf@gnu.org> <20140115162518.GL4762@adacore.com> X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00523.txt.bz2 > Date: Wed, 15 Jan 2014 20:25:18 +0400 > From: Joel Brobecker > Cc: binutils@sourceware.org, gdb-patches@sourceware.org > > But even with this example, it isn't just a repeat. I didn't say it was just a repeat, I said most of it just repeats. > The text before the ChangeLog says what the intent of the patch is, > and provides extra information that usually doesn't go into the > ChangeLog entry. For example, it says "This makes it usable in more > places". Why not have this as part of the log entry. Here's an example (from Emacs): * window.h (struct window): Replace hchild, vchild and buffer slots with a single contents slot. This is possible because each valid window may have either the child window (in vertical or horizontal combination) or buffer to display (for the leaf window). Using that, a lot of operations to traverse and/or change window hierarchies may be simplified. New member horizontal is used to distinguish between horizontal and vertical combinations of internal windows.