public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: implement "watch -location"
Date: Thu, 12 Aug 2010 03:07:00 -0000	[thread overview]
Message-ID: <83eie4v895.fsf@gnu.org> (raw)
In-Reply-To: <m38w4c7qne.fsf@fleche.redhat.com>

> From: Tom Tromey <tromey@redhat.com>
> Date: Wed, 11 Aug 2010 16:04:05 -0600
> 
> This patch steals an idea from Apple's gdb fork, namely "watch -location".
> I wrote this from scratch but in the end it looks pretty similar to what
> they did.

Thanks.

> +@value{GDBN} will evaluate @var{expr}, take the address of the result,
> +and watch that memory.  If the expression's result does not have an

I suggest a slight rewording here:

   ... take the address of the result, and watch the memory at that
   address.

Please also say something about the size of the memory area watched by
such a watchpoint.

The docs are OK with those changes.

  parent reply	other threads:[~2010-08-12  3:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-11 22:04 Tom Tromey
2010-08-11 22:11 ` Michael Snyder
2010-08-11 22:15   ` Tom Tromey
2010-08-12  2:45     ` Hui Zhu
2010-08-12  7:55     ` André Pönitz
2010-08-12  3:07 ` Eli Zaretskii [this message]
2010-08-12  8:17 ` Phil Muldoon
2010-08-13 16:39 ` Jan Kratochvil
2010-08-13 18:27   ` Tom Tromey
2010-08-16 19:54     ` Jan Kratochvil
2010-08-13 18:25 ` Tom Tromey
2010-08-13 19:19   ` Eli Zaretskii
2010-08-13 21:21   ` Jan Kratochvil
2010-08-13 21:24     ` Tom Tromey
2010-08-16 18:13       ` Tom Tromey
2010-08-16 18:43         ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83eie4v895.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).