From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-70784-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 715 invoked by alias); 5 Mar 2010 10:33:27 -0000
Received: (qmail 705 invoked by uid 22791); 5 Mar 2010 10:33:26 -0000
X-SWARE-Spam-Status: No, hits=-0.7 required=5.0 	tests=AWL,BAYES_00,RCVD_IN_SORBS_WEB,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 05 Mar 2010 10:33:18 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KYT00F0017OCC00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 05 Mar 2010 12:33:06 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.126.34.234]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KYT00BSA1B5H0C0@a-mtaout22.012.net.il>; Fri, 05 Mar 2010 12:33:06 +0200 (IST)
Date: Fri, 05 Mar 2010 10:33:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: PATCH: 2/6: Add AVX support (Update document)
In-reply-to: <20100304180408.GA10869@intel.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83eijz2h3i.fsf@gnu.org>
References: <20100304180219.GA10826@intel.com> <20100304180408.GA10869@intel.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-03/txt/msg00229.txt.bz2

> Date: Thu, 4 Mar 2010 10:04:08 -0800
> From: "H.J. Lu" <hongjiu.lu@intel.com>
> 
> This patch updates document for AVX support.  OK to install?

Is it still relevant?

I will review this anyway, in the hope that it will help you submit
the fixed patch down the way.

> +@item x86:xstate=@var{bytes}:xcr0=@var{value}
> +This feature indicates that @value{GDBN} supports x86 XSAVE extended

It will look prettier in print if you use @sc{xsave} instead of
XSAVE.  (The result in the Info manual is the same.)

> +state. @var{bytes} specifies the maximum size in bytes of x86 XSAVE
        ^^
Two spaces between sentences, please (here and elsewhere in your
patch).

> +extended state @value{GDBN} supports. @var{value} specifies the
> +maximum value of the extended control register 0 (the
> +XFEATURE_ENABLED_MASK register) @value{GDBN} supports.  The stub should

XFEATURE_ENABLED_MASK is a C symbol, so it should be in @code.

Thanks.