From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 089B73858012 for ; Mon, 11 Dec 2023 15:45:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 089B73858012 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 089B73858012 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702309539; cv=none; b=wn6a6eZL90Ft+iyJnv0cP5s08gkH441swjmTIibp08Va9GZD6QhSfxVfy6OKxxzv1yLOFHWv/+RFURu6syi0Qc+pl8tEMVOD/yhvsMsq41XGuaN11FC5PQo7X5ABKaLPEPlb2Vpv6sp+eegS7cE+b5A8ENyfe2nU2mOKwW0o2bI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702309539; c=relaxed/simple; bh=VyFJGy2XFf4WgIfBUP31LO4TQlrax894Mq3q2zwpdJw=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=g8jpoQSw++ItUqJ2qkbwDnNl8lH1cOTATDsrdg8JuXyNRxI+FzKd+mOEkWZ4oBZ1AGkPmSMt/4VRAEsjhniWTgmxC/pJeyn9P7ZayDWPOGiVRM0fUuL3hJSI+I6NC4g8f/lPVIwxuyBEQSeYvwVQKTZHg5q3/F/fkRvbsY/nNLI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCiTR-0000Pf-Jl; Mon, 11 Dec 2023 10:45:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=lq0RtCrOBYogcutxdF6VQvhzmhYn9Tucndhm4xn048o=; b=Gh3qHL46+V3G sBuHJy1d9hjzbJRTq3oG8xBysIUpkYo73rDKmEXSbstSMqYqRlWVnOGOwg83FqF0gKi8BUWHTDOXc t+eORjn8Qd1vZFRYLArxvzRUGx3ltfHfEiM94Vsux7gsm+OgH9e2nqnqKosNnzlpSXWLfdNKFpsyB J0izGfoVrGSdFsZsR+Lemd54UrsEwLToxcJ2bammlSAftbt3Qx94Zj05QJfmc987Z8Htc/GZLWxa9 v98DjCCxS8GytFWuWy8EaF2qmPt+MID7K+dKjgOCrVuKfbQaDJ5Y3l7ohz4YD9xvPN+QniLzebZAn sEhac0FKjEUUqEAX6ytXBg==; Date: Mon, 11 Dec 2023 17:44:58 +0200 Message-Id: <83fs08vj45.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey Cc: gdb-patches@sourceware.org In-Reply-To: <87edfsg4p8.fsf@tromey.com> (message from Tom Tromey on Mon, 11 Dec 2023 08:05:23 -0700) Subject: Re: [PATCH 6/6] Implement DAP cancellation References: <20231201-dap-cancel-v1-0-872022fc328a@adacore.com> <20231201-dap-cancel-v1-6-872022fc328a@adacore.com> <83cyvpapa1.fsf@gnu.org> <87edfsg4p8.fsf@tromey.com> X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Tom Tromey > Cc: Tom Tromey , gdb-patches@sourceware.org > Date: Mon, 11 Dec 2023 08:05:23 -0700 > > >>>>> "Eli" == Eli Zaretskii writes: > > >> From: Tom Tromey > >> Date: Fri, 01 Dec 2023 08:41:02 -0700 > >> > >> This implements DAP cancellation. A new object is introduced that > >> handles the details of cancellation. While cancellation is inherently > >> racy, this code attempts to make it so that gdb doesn't inadvertently > >> cancel the wrong request. > >> > >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30472 > >> --- > >> gdb/doc/gdb.texinfo | 16 +++++++ > >> gdb/python/lib/gdb/dap/server.py | 91 ++++++++++++++++++++++++++++++++++++++-- > >> gdb/testsuite/gdb.dap/pause.exp | 71 +++++++++++++++++++++++++++++++ > >> 3 files changed, 175 insertions(+), 3 deletions(-) > > Eli> Thanks, the documentation part is OK. > > Eli> Reviewed-By: Eli Zaretskii > > Thanks. I realized I should start adding NEWS entries for DAP changes. > > Assuming the earlier one is approved: > > +* Debugger Adapter Protocol changes > + > + ** GDB now emits the "process" event. > + > > ... then for this cancel patch I'd propose adding: > > ** GDB now supports the "cancel" request. This is OK. Approved-By: Eli Zaretskii