Re: [PATCH v9 05/10] python: Introduce gdb.RecordAuxiliary class.

[Eli Zaretskii <eliz@gnu.org>]

> Cc: Felix Willgerodt <felix.willgerodt@intel.com>
> Date: Tue,  4 Jul 2023 14:35:55 +0200
> From: Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
> 
> Auxiliary instructions are no real instructions and get their own object
> class, similar to gaps. gdb.Record.instruction_history is now possibly a
> list of gdb.RecordInstruction, gdb.RecordGap or gdb.RecordAuxiliary
> objects.
> 
> This patch is in preparation for the new ptwrite feature, which is based on
> auxiliary instructions.
> ---
>  gdb/doc/python.texi           | 13 ++++++
>  gdb/python/py-record-btrace.c | 81 +++++++++++++++++++++++++++++------
>  gdb/python/py-record-btrace.h |  3 ++
>  gdb/python/py-record.c        | 62 +++++++++++++++++++++++++--
>  gdb/python/py-record.h        |  7 +++
>  5 files changed, 150 insertions(+), 16 deletions(-)

Thanks.

> +@defvar RecordAuxiliary.number
> +An integer identifying this auxiliary.  @code{number} corresponds to the numbers
> +seen in @code{record instruction-history} (@pxref{Process Record and Replay}).

I think "number" should be in @var, like this:

 +@defvar RecordAuxiliary.@var{number}
 +An integer identifying this auxiliary.  @var{number} corresponds to the numbers
 +seen in @code{record instruction-history} (@pxref{Process Record and Replay}).

because "number" is not a literal string, it stands for some numerical
string.  Right?

Reviewed-By: Eli Zaretskii <eliz@gnu.org>