From: Eli Zaretskii <eliz@gnu.org>
To: "Alexandra Hájková" <ahajkova@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] remote.c: Allow inferior to reply with an error
Date: Fri, 13 Jan 2023 15:16:04 +0200 [thread overview]
Message-ID: <83fscea82z.fsf@gnu.org> (raw)
In-Reply-To: <20230113115910.3215524-1-ahajkova@redhat.com> (=?utf-8?Q?AlexandraH=C3=A1jkov=C3=A1=40sourceware=2Eorg?=)
> From: AlexandraHájková@sourceware.org
> Date: Fri, 13 Jan 2023 12:59:10 +0100
>
> From: Alexandra Hájková <ahajkova@redhat.com>
>
> When gdb communicates with some kind of gdbserver or gdbserver
> stub over the remote protocol, the only possible response to
> the QSetWorkingDir packet is "OK". If the remote will reply
> with anything else, gdb will complain about the unexpected reply.
>
> [remote] Sending packet: $QSetWorkingDir:2f746d70#bb
> [remote] Packet received: E00
> Remote replied unexpectedly while setting the inferior's working
> directory: E00
> (gdb)
>
> Allow remote to send an error message over as a QSetWorkingDir
> packet reply.
>
> [remote] Sending packet: $QSetWorkingDir:2f746d70#bb
> [remote] Packet received: E.directory does not exist
> Remote failed to set working directory: directory does not exist.
>
> ---
> V2 does not change the behaviour of gdb in a case it wasn't possible to
> set the inferior's working directory. It just allows to pass the error
> message to gdb.
>
> gdb/doc/gdb.texinfo | 3 +++
> gdb/remote.c | 12 +++++++++---
> 2 files changed, 12 insertions(+), 3 deletions(-)
OK for the documentation part.
Thanks.
next prev parent reply other threads:[~2023-01-13 13:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 11:59
2023-01-13 13:16 ` Eli Zaretskii [this message]
2023-01-17 16:30 ` Andrew Burgess
2023-01-18 9:48 ` Mark Wielaard
2023-01-18 18:10 ` Andrew Burgess
2023-01-18 13:37 ` Alexandra Petlanova Hajkova
2023-01-18 18:19 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fscea82z.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=ahajkova@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).