From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 804D13858D35 for ; Thu, 5 Jan 2023 07:11:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 804D13858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDKPc-0000K7-T3; Thu, 05 Jan 2023 02:11:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yk8Mxl2Cz6RBjsF5i4SYWYZzhA8j+9AMM8qEITkKdRA=; b=f4mRJuCHgh+E GM6WPoztLVZMCT13icyfnec9UXpw83Oi1kH/pMI2NTcgYZwmVPGzQGEe+SwY18p9yCWAifjntqx0R FOz2Ok7tXSgwKaWVdYNuKzafWQOPT6lxEs9b+cKHkgxxelEX0VLZLXN9b7b/g1th3FX0iir15/jSU 1fBa99jMWjSznxcVyEZDPJLfy+iVql3mlh62Toed9jyEtZzGxSbK3uC7fjhwnAaPDC0OHiGDUUfIp SKPQMobOfyeYWCHznWmJ+VRCHkpOzzHSzvMj3j7uuVDZ+WIGeDVjdvdjAyxOeENp6rvnABtkTkFjZ s9me0RT+Pw1vOnWZkwPUVg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDKPc-0002sD-2u; Thu, 05 Jan 2023 02:11:40 -0500 Date: Thu, 05 Jan 2023 09:11:53 +0200 Message-Id: <83fscpxxom.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey Cc: simark@simark.ca, cbiesinger@google.com, gdb-patches@sourceware.org, luis.machado@arm.com In-Reply-To: <878rii9bg3.fsf@tromey.com> (message from Tom Tromey on Wed, 04 Jan 2023 15:33:48 -0700) Subject: Re: Two observations using GDB 13 snapshot References: <83h6xugc5v.fsf@gnu.org> <835ye7e9jw.fsf@gnu.org> <87h6xrks77.fsf@tromey.com> <83mt7idacj.fsf@gnu.org> <87fsd4elb2.fsf@tromey.com> <83o7rs4qmg.fsf@gnu.org> <87cz84dasj.fsf@tromey.com> <835ydw20bw.fsf@gnu.org> <87wn6bbi5m.fsf@tromey.com> <83sfgz8m9i.fsf@gnu.org> <87o7rnb0ya.fsf@tromey.com> <83a6368chf.fsf@gnu.org> <87k02aaxc8.fsf@tromey.com> <83wn6a6n21.fsf@gnu.org> <587b899f-0f93-530a-7313-d4e1f9e501b9@simark.ca> <835ydt6jzw.fsf@gnu.org> <83wn63z81w.fsf@gnu.org> <46d7fd4b-d5f0-0007-3e88-20345e0e0584@simark.ca> <831qoayxuu.fsf@gnu.org> <878rii9bg3.fsf@tromey.com> X-Spam-Status: No, score=1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Tom Tromey > Cc: Simon Marchi , cbiesinger@google.com, > tom@tromey.com, gdb-patches@sourceware.org, luis.machado@arm.com > Date: Wed, 04 Jan 2023 15:33:48 -0700 > > >>>>> "Eli" == Eli Zaretskii writes: > > Eli> Looks like indeed strcasecmp is the culprit. With the patch below, > Eli> which replaces strcasecmp with a simple case-insensitive comparison > Eli> that only works with ASCII, the phase of reading symbols from gdb.exe > Eli> goes down to just 6 seconds, which is basically the same time as with > Eli> GDB 12. > > Thank you. Hopefully the other patch I have pending, which does > something similar, should have the same effect. Thanks, I applied that patch (modulo the testsuite parts), and I can confirm that it is almost as fast as the simple one I posted before: 7.5 sec vs 6.2 sec to read the symbols from gdb.exe. However, what does this change mean in terms of GDB's support for symbols with non-ASCII names? AFAIU, libiberty's TOLOWER only handles ASCII characters. If it's okay for GDB to compare case-insensitively only ASCII characters, then is the above patch mature enough to go to the gdb-13 branch?