From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118821 invoked by alias); 23 Nov 2019 07:21:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118808 invoked by uid 89); 23 Nov 2019 07:21:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 23 Nov 2019 07:21:25 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55995) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iYPjQ-0007xB-5k; Sat, 23 Nov 2019 02:21:24 -0500 Received: from [176.228.60.248] (port=2371 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iYPjP-0002wB-M3; Sat, 23 Nov 2019 02:21:24 -0500 Date: Sat, 23 Nov 2019 07:21:00 -0000 Message-Id: <83ftifukge.fsf@gnu.org> From: Eli Zaretskii To: tromey@sourceware.org, andrew.burgess@embecosm.com, gdb-patches@sourceware.org In-reply-to: <20191122235414.5B2902816F@gnutoolchain-gerrit.osci.io> Subject: Re: [review v2] Allow using less horizontal space in TUI source window References: <20191122235414.5B2902816F@gnutoolchain-gerrit.osci.io> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-11/txt/msg00786.txt.bz2 > Date: Fri, 22 Nov 2019 18:54:13 -0500 > From: "Tom Tromey (Code Review)" > Cc: Andrew Burgess > > Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/605 > ...................................................................... > > Allow using less horizontal space in TUI source window > > The source window currently uses a field width of 6 for line numbers, > and it further aligns to the next tab stop. This seemed a bit > wasteful of horizontal space to me, so I changed that in an earlier > patch. > > However, that change wasn't universally popular. This patch instead > adds the option to use less horizontal space in the TUI source window. > > gdb/ChangeLog > 2019-11-22 Tom Tromey > > * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits" > parameter. > * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits" > parameter. > * tui/tui-win.h (compact_source): Declare. > * tui/tui-win.c (compact_source): New global. > (tui_set_compact_source, tui_show_compact_source): New functions. > (_initialize_tui_win): Add "compact-source" setting. > * tui/tui-source.c (tui_source_window::set_contents): Handle > compact_source setting. > * tui/tui-disasm.c (tui_disasm_window::set_contents): Update. > * NEWS: Document new setting. > > gdb/doc/ChangeLog > 2019-11-22 Tom Tromey > > * gdb.texinfo (TUI Configuration): Document new setting. Thanks, the documentation parts are OK.