From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-123650-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7825 invoked by alias); 18 Jun 2015 12:11:25 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 7792 invoked by uid 89); 18 Jun 2015 12:11:25 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout22.012.net.il
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Jun 2015 12:11:18 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NQ50020034N8600@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Thu, 18 Jun 2015 15:11:10 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NQ5001SC36LWZ90@a-mtaout22.012.net.il>; Thu, 18 Jun 2015 15:11:10 +0300 (IDT)
Date: Thu, 18 Jun 2015 12:11:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 1/5] Introduce build_debug_file_name
In-reply-to: <20150618105528.GA2644@blade.nx>
To: Gary Benson <gbenson@redhat.com>
Cc: gdb-patches@sourceware.org, cedric.buissart@gmail.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83fv5pkyi1.fsf@gnu.org>
References: <1434447768-17328-1-git-send-email-gbenson@redhat.com> <1434447768-17328-2-git-send-email-gbenson@redhat.com> <83zj3zn21q.fsf@gnu.org> <20150617094734.GA9671@blade.nx> <83a8vymgmg.fsf@gnu.org> <20150618105528.GA2644@blade.nx>
X-IsSubscribed: yes
X-SW-Source: 2015-06/txt/msg00385.txt.bz2

> Date: Thu, 18 Jun 2015 11:55:28 +0100
> From: Gary Benson <gbenson@redhat.com>
> Cc: gdb-patches@sourceware.org, cedric.buissart@gmail.com
> 
> > But won't we produce "d://foo/bar" as result?
> 
> No.  build_debug_file_name strips both leading and trailing slashes.
> The only ways to get a double slash from build_debug_file_name is to
> pass one in in the middle of a string.
> 
>   build_debug_file_name ("d:", "foo", "bar")          -> "d:/foo/bar"
>   build_debug_file_name ("d:/", "/foo", "bar")        -> "d:/foo/bar"
>   build_debug_file_name ("d:///", "///foo///", "bar") -> "d:/foo/bar"
> 
> but
> 
>   build_debug_file_name("d://foo", "bar") -> "d://foo/bar"
>   
> > > I don't believe this series should be blocked unless it breaks
> > > something that actually worked before.
> > 
> > If a fix is very simple, why not make it?
> 
> I don't understand, what are you asking me to fix?

Nothing, given the above.

Thanks.