From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16944 invoked by alias); 19 Dec 2014 08:24:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16922 invoked by uid 89); 19 Dec 2014 08:24:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout29.012.net.il Received: from mtaout29.012.net.il (HELO mtaout29.012.net.il) (80.179.55.185) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Dec 2014 08:24:03 +0000 Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NGT00000LOLYO00@mtaout29.012.net.il> for gdb-patches@sourceware.org; Fri, 19 Dec 2014 10:21:27 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NGT00NS1LVRSR30@mtaout29.012.net.il>; Fri, 19 Dec 2014 10:21:27 +0200 (IST) Date: Fri, 19 Dec 2014 08:24:00 -0000 From: Eli Zaretskii Subject: Re: [patch] compile: rm -rf -> ftw()+rmdir()+unlink() [Re: [patch] compile: Fix MinGW build] In-reply-to: <20141218212353.GA23599@host2.jankratochvil.net> To: Jan Kratochvil Cc: palves@redhat.com, ktietz@redhat.com, sellcey@imgtec.com, brobecker@adacore.com, yao@codesourcery.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83fvcct5cw.fsf@gnu.org> References: <20141217210144.GA26674@host2.jankratochvil.net> <549206B1.40902@redhat.com> <20141218181432.GA19996@host2.jankratochvil.net> <54931BBB.3080304@redhat.com> <20141218184123.GA20422@host2.jankratochvil.net> <549325FB.9040705@redhat.com> <20141218210445.GA23134@host2.jankratochvil.net> <83h9wsu0i3.fsf@gnu.org> <20141218212353.GA23599@host2.jankratochvil.net> X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00566.txt.bz2 > Date: Thu, 18 Dec 2014 22:23:53 +0100 > From: Jan Kratochvil > Cc: palves@redhat.com, ktietz@redhat.com, sellcey@imgtec.com, > brobecker@adacore.com, yao@codesourcery.com, > gdb-patches@sourceware.org > > On Thu, 18 Dec 2014 22:11:16 +0100, Eli Zaretskii wrote: > > If this is a problem, how about writing down the requirements? > > I was more general above. So was I. If you think our requirements are not detailed enough, with the result of complicating the patch submission process and the job of contributors, I think we should try to put more details into the existing documentation. Of course, some requirements that come up during the review cannot possibly be codified, because they are general principles or minor preferences that are too many to write down. I don't think we can avoid that, but we could try. E.g., after each such issue comes up, we could ask ourselves whether it is worth adding to the documentation.