From: Eli Zaretskii <eliz@gnu.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3 14/14] the "compile" command
Date: Fri, 21 Nov 2014 19:47:00 -0000 [thread overview]
Message-ID: <83fvdctjyi.fsf@gnu.org> (raw)
In-Reply-To: <20141121184132.GA8400@host2.jankratochvil.net>
> Date: Fri, 21 Nov 2014 19:41:32 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: gdb-patches@sourceware.org
>
> > Then maybe we need to tell what "persistent" means in this context.
> > Something like "visible to the rest of the program for the duration of
> > this run".
>
> I find this was said by "and only exist as long as the injected object code
> exists.". But I have therefore changed the sentence to:
> Variables and types that are created as part of the @code{compile}
> command are not visible to the rest of the program for the duration of
> this run.
>
> BTW I would say s/this run/its run/.
That's also fine.
> > OK, then let's say so explicitly. Something like
> >
> > Types defined in the @code{compile} will no longer be available in
> > the next @code{compile} command.
>
> I used it as you wrote. Although I would write:
> Types defined in the @code{compile} command will no longer be
> available in the next @code{compile} command.
That'd be fine as well.
I think the patch can go in now. Thanks.
next prev parent reply other threads:[~2014-11-21 19:47 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-01 21:45 [PATCH v3 00/14] let gdb reuse gcc's C compiler Jan Kratochvil
2014-11-01 21:46 ` [PATCH v3 02/14] add gcc/gdb interface files Jan Kratochvil
2014-11-03 12:51 ` Yao Qi
2014-11-03 12:56 ` Jan Kratochvil
2014-11-03 13:24 ` Yao Qi
2014-11-01 21:46 ` [PATCH v3 03/14] add some missing ops to DWARF assembler Jan Kratochvil
2014-11-01 21:46 ` [PATCH v3 07/14] add gnu_triplet_regexp gdbarch method Jan Kratochvil
2014-11-01 21:46 ` [PATCH v3 06/14] add infcall_mmap and gcc_target_options gdbarch methods Jan Kratochvil
2014-11-01 21:46 ` [PATCH v3 01/14] introduce ui_file_write_for_put Jan Kratochvil
2014-11-01 21:46 ` [PATCH v3 05/14] add dummy frame destructor Jan Kratochvil
2014-11-01 21:46 ` [PATCH v3 04/14] add make_unqualified_type Jan Kratochvil
2014-11-01 21:46 ` [PATCH v3 08/14] introduce call_function_by_hand_dummy Jan Kratochvil
2014-11-01 21:47 ` [PATCH v3 12/14] add linux_infcall_mmap Jan Kratochvil
2014-11-11 16:43 ` Pedro Alves
2014-11-23 19:11 ` Jan Kratochvil
2014-12-12 14:38 ` Pedro Alves
2014-11-01 21:47 ` [PATCH v3 11/14] export dwarf2_reg_to_regnum_or_error Jan Kratochvil
2014-11-01 21:47 ` [PATCH v3 13/14] add s390_gcc_target_options Jan Kratochvil
2014-11-01 21:47 ` [PATCH v3 10/14] make dwarf_expr_frame_base_1 public Jan Kratochvil
2014-11-01 21:47 ` [PATCH v3 09/14] split dwarf2_fetch_cfa_info from dwarf2_compile_expr_to_ax Jan Kratochvil
2014-11-01 21:48 ` [PATCH v3 14/14] the "compile" command Jan Kratochvil
2014-11-02 16:03 ` Eli Zaretskii
2014-11-20 21:24 ` Jan Kratochvil
2014-11-21 7:58 ` Eli Zaretskii
2014-11-21 18:41 ` Jan Kratochvil
2014-11-21 19:47 ` Eli Zaretskii [this message]
2014-11-03 13:08 ` Yao Qi
2014-11-14 18:43 ` Jan Kratochvil
2014-11-11 18:53 ` Pedro Alves
2014-11-23 18:36 ` Jan Kratochvil
2014-12-12 14:38 ` Pedro Alves
2014-11-01 21:52 ` [PATCH v3 00/14] let gdb reuse gcc's C compiler Jan Kratochvil
2014-11-01 21:56 ` Jan Kratochvil
2014-11-03 12:47 ` Yao Qi
2014-11-03 12:49 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fvdctjyi.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).