From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15090 invoked by alias); 20 Jun 2014 07:14:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15074 invoked by uid 89); 20 Jun 2014 07:14:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout22.012.net.il Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Jun 2014 07:14:42 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0N7G00M00HDIYN00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 20 Jun 2014 10:14:39 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N7G00M1IHGESK40@a-mtaout22.012.net.il>; Fri, 20 Jun 2014 10:14:39 +0300 (IDT) Date: Fri, 20 Jun 2014 07:14:00 -0000 From: Eli Zaretskii Subject: Re: [PING][PATCH] GDB/testsuite: Add a way to send multiple init commands In-reply-to: To: "Maciej W. Rozycki" Cc: tromey@redhat.com, keiths@redhat.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83fvj0rr1q.fsf@gnu.org> References: <87a99jwj4u.fsf@fleche.redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00724.txt.bz2 > Date: Fri, 20 Jun 2014 00:39:32 +0100 > From: "Maciej W. Rozycki" > CC: Keith Seitz , Eli Zaretskii , > > On Wed, 11 Jun 2014, Maciej W. Rozycki wrote: > > > On Wed, 11 Jun 2014, Tom Tromey wrote: > > > > > Maciej> 2014-06-10 Maciej W. Rozycki > > > Maciej> Maciej W. Rozycki > > > > > > Maciej> * lib/gdb.exp (gdb_run_cmd): Process `gdb_init_commands'. > > > Maciej> * lib/mi-support.exp (mi_run_cmd): Process `gdb_init_commands'. > > > > > > I like Keith's proposed cleanup. > > > > > > Maciej> + set commands [target_info gdb_init_commands]; > > > > > > Extraneous ";". There are a few of these. > > > > Sigh, it just shows my lack of experience with TCL back in 2005. I've > > been pondering an update to the change to avoid some code duplication, so > > given I had to touch it anyway I went ahead and did it. Here's the > > result. > > > > It has been lightly tested with gdb.base/advance.exp, with neither > > setting defined, with `gdb_init_command' only, with `gdb_init_commands' > > only having a single element, with `gdb_init_commands' only having two > > elements and with both `gdb_init_command' and `gdb_init_commands' defined, > > the latter having two elements. It has been also smoke-tested with > > gdb.mi/mi-break.exp, with the last arrangement mentioned above only. > > > > > I think this patch should also update testsuite/README to document the > > > new setting. > > > > And presumably the old one as well, right? Cc-ing Eli for this part. > > > > 2014-06-11 Maciej W. Rozycki > > Maciej W. Rozycki > > > > * lib/gdb.exp (gdb_run_cmd): Process `gdb_init_commands'. > > * lib/mi-support.exp (mi_run_cmd): Process `gdb_init_commands'. > > * README (Board Settings): Document `gdb_init_command' and > > `gdb_init_commands'. > > Ping. Not sure why I'm one of the addressees: there's no documentation in this patch.