From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30384 invoked by alias); 20 May 2014 16:12:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30373 invoked by uid 89); 20 May 2014 16:12:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout26.012.net.il Received: from mtaout26.012.net.il (HELO mtaout26.012.net.il) (80.179.55.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 May 2014 16:12:25 +0000 Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0N5V00D00R98ZI00@mtaout26.012.net.il> for gdb-patches@sourceware.org; Tue, 20 May 2014 19:09:14 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N5V005CNRJEOFA0@mtaout26.012.net.il>; Tue, 20 May 2014 19:09:14 +0300 (IDT) Date: Tue, 20 May 2014 16:12:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH v2 1/3] btrace: control memory access during replay In-reply-to: <1400587236-18836-1-git-send-email-markus.t.metzger@intel.com> To: Markus Metzger Cc: palves@redhat.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83fvk4bf9u.fsf@gnu.org> References: <1400587236-18836-1-git-send-email-markus.t.metzger@intel.com> X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00432.txt.bz2 > From: Markus Metzger > Cc: gdb-patches@sourceware.org, Eli Zaretskii > Date: Tue, 20 May 2014 14:00:34 +0200 > > The btrace record target does not trace data. We therefore do not allow > accessing read-write memory during replay. > > In some cases, this might be useful to advanced users, though, who we assume > to know what they are doing. > > Add a set|show command pair to turn this memory access restriction off. Thanks. > doc/ > * gdb.texinfo: Document it. That's not how we format ChangeLog entries in gdb/doc/. Please state the node name (as if it were a function, in parentheses). > +@kindex set record btrace > +The btrace record target does not trace data. As a convenience, > +when replaying, GDB reads read-only memory off the live program @value{GDBN} > +Control the behavior of the @code{btrace} recording method when Please be consistent about the markup of "btrace": either plain text or @code{}; pick one and use it everywhere. > +accessing memory during replay. If READ-ONLY (the default), > +@value{GDBN} will only allow accesses to read-only memory. > +If READ-WRITE, @value{GDBN} will allow accesses to read-only and to > +read-write memory. Beware that the accessed memory corresponds READ-ONLY and READ-WRITE should be in @code and in lower case. The documentation part is OK with those fixed.