From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@redhat.com>
Cc: jan.kratochvil@redhat.com, gdb-patches@sourceware.org
Subject: Re: [3/4] RFC: add DWARF index support
Date: Thu, 08 Jul 2010 18:25:00 -0000 [thread overview]
Message-ID: <83fwzt7s16.fsf@gnu.org> (raw)
In-Reply-To: <m3d3ux7vsy.fsf@fleche.redhat.com>
> From: Tom Tromey <tromey@redhat.com>
> Cc: gdb-patches@sourceware.org
> Date: Thu, 08 Jul 2010 11:00:45 -0600
>
> +@node Index Files
> +@section Index Files Speed Up GDB
^^^
Should be "@value{GDBN}".
> +@cindex @file{.gnu-index} file
^^^^^^^^^^
".gdb-index", I believe.
> +When @value{GDBN} finds a symbol file, it scans the symbols in the
> +file in order to construct an internal symbol table. This lets most
> +@value{GDBN} operations work quickly----at the cost of a delay early
^^^^
One dash too much.
> +To create an index file, use the @code{maint save-gdb-index} command:
Why are we putting this command in the "maint" class? It sounds like
a first-class user-level feature, not a GDB maintainer's feature.
> +@item maint save-gdb-index @var{directory}
> +@kindex maint save-gdb-index
> +Create an index file for each symbol file currently known by
> +@value{GDBN}. Each file is named after its corresponding symbol file,
> +with @samp{.gdb-index} appended, and is written into the given
> +directory.
^^^^^^^^^
"@var{directory}"
Btw, why isn't this argument optional?
> +@smallexample
> +$ objcopy --add-section .gdb_index=symfile.gdb-index --set-section-flags .gdb_index=readonly symfile symfile
> +@end smallexample
This line is too long for @smallexample, please split it into two
(with a backslash between them).
> + out_file = fopen (filename, "w");
This should use "wb", I believe, or it will not DTRT on DOS/Windows.
> + add_cmd ("save-gdb-index", class_maintenance, save_gdb_index_command,
> + _("Save the a .gdb-index file"),
^^^^^
"the" or "a"?
Thanks.
next prev parent reply other threads:[~2010-07-08 18:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 22:46 Tom Tromey
2010-07-04 18:18 ` Jan Kratochvil
2010-07-04 19:28 ` Jan Kratochvil
2010-07-06 16:50 ` Tom Tromey
2010-07-06 17:11 ` Jan Kratochvil
2010-07-06 17:31 ` Tom Tromey
2010-07-06 17:36 ` Jan Kratochvil
2010-07-06 17:35 ` Tom Tromey
2010-07-06 17:37 ` Jan Kratochvil
2010-07-08 17:01 ` Tom Tromey
2010-07-08 18:25 ` Eli Zaretskii [this message]
2010-07-08 20:35 ` Tom Tromey
2010-07-08 20:52 ` Eli Zaretskii
2010-07-08 17:02 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fwzt7s16.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).