From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-74265-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8953 invoked by alias); 8 Jul 2010 18:25:28 -0000
Received: (qmail 8932 invoked by uid 22791); 8 Jul 2010 18:25:25 -0000
X-SWARE-Spam-Status: No, hits=-0.6 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL,TW_BJ,TW_JC,TW_YM
X-Spam-Check-By: sourceware.org
Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Jul 2010 18:25:19 +0000
Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0L59003004DZRO00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Thu, 08 Jul 2010 21:24:13 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([77.127.120.144]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L59001LS4GCR050@a-mtaout21.012.net.il>; Thu, 08 Jul 2010 21:24:13 +0300 (IDT)
Date: Thu, 08 Jul 2010 18:25:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [3/4] RFC: add DWARF index support
In-reply-to: <m3d3ux7vsy.fsf@fleche.redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: jan.kratochvil@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83fwzt7s16.fsf@gnu.org>
References: <m3wrtgp2ak.fsf@fleche.redhat.com> <20100704181758.GA30603@host0.dyn.jankratochvil.net> <m38w5oeeqv.fsf@fleche.redhat.com> <20100706171142.GA24412@host0.dyn.jankratochvil.net> <m3d3ux7vsy.fsf@fleche.redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-07/txt/msg00156.txt.bz2

> From: Tom Tromey <tromey@redhat.com>
> Cc: gdb-patches@sourceware.org
> Date: Thu, 08 Jul 2010 11:00:45 -0600
> 
> +@node Index Files
> +@section Index Files Speed Up GDB
                                 ^^^
Should be "@value{GDBN}".

> +@cindex @file{.gnu-index} file
                 ^^^^^^^^^^
".gdb-index", I believe.

> +When @value{GDBN} finds a symbol file, it scans the symbols in the
> +file in order to construct an internal symbol table.  This lets most
> +@value{GDBN} operations work quickly----at the cost of a delay early
                                       ^^^^
One dash too much.

> +To create an index file, use the @code{maint save-gdb-index} command:

Why are we putting this command in the "maint" class?  It sounds like
a first-class user-level feature, not a GDB maintainer's feature.

> +@item maint save-gdb-index @var{directory}
> +@kindex maint save-gdb-index
> +Create an index file for each symbol file currently known by
> +@value{GDBN}.  Each file is named after its corresponding symbol file,
> +with @samp{.gdb-index} appended, and is written into the given
> +directory.
   ^^^^^^^^^
"@var{directory}"

Btw, why isn't this argument optional?

> +@smallexample
> +$ objcopy --add-section .gdb_index=symfile.gdb-index --set-section-flags .gdb_index=readonly symfile symfile
> +@end smallexample

This line is too long for @smallexample, please split it into two
(with a backslash between them).

> +  out_file = fopen (filename, "w");

This should use "wb", I believe, or it will not DTRT on DOS/Windows.

> +  add_cmd ("save-gdb-index", class_maintenance, save_gdb_index_command,
> +	   _("Save the a .gdb-index file"),
                   ^^^^^
"the" or "a"?

Thanks.