From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-74137-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22044 invoked by alias); 1 Jul 2010 17:31:38 -0000
Received: (qmail 22034 invoked by uid 22791); 1 Jul 2010 17:31:38 -0000
X-SWARE-Spam-Status: No, hits=-0.2 required=5.0	tests=AWL,BAYES_05,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL,TW_VC
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Jul 2010 17:31:34 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0L4W001003B65L00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Thu, 01 Jul 2010 20:31:31 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([84.229.12.240]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L4W00L7V3CI0A80@a-mtaout22.012.net.il>; Thu, 01 Jul 2010 20:31:31 +0300 (IDT)
Date: Thu, 01 Jul 2010 17:31:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA/DOC] record pic
In-reply-to: <AANLkTikzyrfRqeBzxLBF35CHgFtktEO65khIGUaU83fB@mail.gmail.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83fx039kel.fsf@gnu.org>
References: <AANLkTikzyrfRqeBzxLBF35CHgFtktEO65khIGUaU83fB@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-07/txt/msg00028.txt.bz2

> From: Hui Zhu <teawater@gmail.com>
> Date: Thu, 1 Jul 2010 15:12:25 +0800
> 
> +record pic [<FILENAME>]
> +  Save the execution log to a vcg file.

What's a vcg file?

> +set record pic hide-nofunction on|off
> +  Set or show whether `record pic' hide the nodes that don't have
                                      ^^^^
"hides"

But what does it mean to "hide the nodes"?

> +set record pic hide-nosource on|off
> +  Set or show whether `record pic' hide the nodes that don't have
                                      ^^^^
"hides"

> +  Set or show whether `record pic' hide the nodes that have the
                                      ^^^^
"hides"

> +Default filename is @file{gdb_record_@var{process_id}}.vcg,
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@file{gdb_record_@var{process_id}.vcg}

> +When @var{type} is set to @code{line} (the default), each node of vcg
> +file that @code{record pic} saved will be a line of the inferior.
> +
> +When @var{type} is set to @code{function}, each node of vcg file that
> +@code{record pic} saved will be a function of the inferior.

This is a charade that I cannot unlock.  "Node"? "each node will be a
line"?  What does all that mean?

I think it would help if you explain up front what is the VCG file,
how it can be used once created, and what is the significance of
having each "node" in it be line or function.  Then this text will
make sense.

> +Set whether @code{record pic} hide the nodes that don't have
                                 ^^^^
"hides"

> +Set whether @code{record pic} hide the nodes that don't have
                                 ^^^^
"hides"

> +Set whether @code{record pic} hide the nodes that have the same
                                 ^^^^
"hides"

I will get back and review the rest when you add those explanations
and I understand better what is this all about.

Thanks.