From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 1BE3A3875DDD for ; Fri, 29 Sep 2023 14:42:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1BE3A3875DDD Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmEhb-0002qD-1S; Fri, 29 Sep 2023 10:42:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=brc0EVuOu3Fzs2cgWFS5ofTS6FrENI4eYlBQEWhH1G8=; b=Ed+BoPdGN47Q dw4Jr/aXVcIvfae49R1HebHB8Qn7q1rsSBy6Wvl7ebvqYstL/Ol0cZJCpvdz9qj2bogyW+yZu9qRl +1tVfwa9dy0YvMrXEG1aBEKDSQlzSE8glES1bET28ZTZDPTkY+8EdcgTrPzeFJ8UkDIz853WG29T8 XjC7wj/qQQEQlbvNI5+bMYUCdBPhliUNFJE1EAKYK7NykjDDau+s5G8dmg3mBAPb6KeWKrnuBVi6y 7aOa8eeNDUXJh1iGQxnCbiG+cH3GoW964PHHbjxI31M/CPO7n3/1UEZCtIN+uErc2FU0bCgSgrSh0 xIt211atW6Sh2duMp735FQ==; Date: Fri, 29 Sep 2023 17:42:25 +0300 Message-Id: <83h6ndyram.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey Cc: aburgess@redhat.com, gdb-patches@sourceware.org In-Reply-To: <87msx62mh5.fsf@tromey.com> (message from Tom Tromey via Gdb-patches on Thu, 28 Sep 2023 12:15:18 -0600) Subject: Re: [PATCH 9/9] gdb: use reopen_exec_file from reread_symbols References: <87msxi8dcv.fsf@tromey.com> <877coawcd9.fsf@redhat.com> <87msx62mh5.fsf@tromey.com> X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Cc: Tom Tromey , Andrew Burgess via Gdb-patches > > Date: Thu, 28 Sep 2023 12:15:18 -0600 > From: Tom Tromey via Gdb-patches > > >>>>> "Andrew" == Andrew Burgess writes: > > Andrew> I didn't fully understand all the discussion w.r.t. gnulib stat vs > Andrew> system stat, but I'm hoping the change above, which is less that your > Andrew> originally proposed full change, might be mergable. > > FTR (and IIUC) the issue is that gnulib's stat yields different times on > Windows hosts, because it tries to handle the timezone -- on Unix, stat > reports in UTC, but on Windows it may report in local time. Are you sure? That's not what I know: AFAIK on Windows 'stat' reports times in UTC, not in local time. At least for some (relatively old) implementation of MSVCRT.DLL, the Windows libc, for which I have sources, 'stat' clearly converts the file's times to UTC. This page: https://learn.microsoft.com/en-us/previous-versions/visualstudio/visual-studio-2013/14h5k7ff(v=vs.120) also seems to imply that file times are indeed in UTC. If we are unsure, we should talk to the Gnulib folks about this, they probably know more about that.