From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Mxk8=BB=gnu.org=eliz@sourceware.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
	by sourceware.org (Postfix) with ESMTPS id 920473858D39
	for <gdb-patches@sourceware.org>; Fri, 12 May 2023 06:28:52 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 920473858D39
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org
Received: from fencepost.gnu.org ([2001:470:142:3::e])
	by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.90_1)
	(envelope-from <eliz@gnu.org>)
	id 1pxMGq-0003t7-5E; Fri, 12 May 2023 02:28:52 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
	s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
	mime-version; bh=86O0C9J6xmEyPMn1lIS3F7hMc2Y59/g2HCdqu+SD6wY=; b=qSLgkBGHASzi
	bNGfHgsCv+tCfGoJSuFMyR78QTvV8+2OiIMs80oSu6/GMdMYOWjIrN8LWiAHYA3vZFu/JzotfMLNl
	krbIdYlJgkemG/qtm0RHTy/lzeZRjHVYq+h9OOb5AHcty/biRyMjQ9YghuFxnXQ2eaHsIMfmce39l
	eUuBHFhCpFOWXC3ucScnZfQrD3Jvxs8EsckBkgO1r47RdRf2CjKMOUeK4AUNz5NvsQdkUOO3iNZeE
	/PE15xcjLEETGH2E6ES2o3bOsaoqtKxnp7z3icIR3K7Yj2oiVmoeF6rCxbJKhdy7iYOA0N5M28dox
	o8F/QlITY2kjCUyftY1KBg==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.90_1)
	(envelope-from <eliz@gnu.org>)
	id 1pxMGp-0004mW-Ai; Fri, 12 May 2023 02:28:51 -0400
Date: Fri, 12 May 2023 09:30:01 +0300
Message-Id: <83h6si3vva.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Aaron Merey <amerey@redhat.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <20230511232203.247173-1-amerey@redhat.com> (message from Aaron
	Merey via Gdb-patches on Thu, 11 May 2023 19:22:03 -0400)
Subject: Re: [PATCH] gdb/cli-out.c: clear_current_line shouldn't trigger
 pagination prompt
References: <20230511232203.247173-1-amerey@redhat.com>
X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

> Cc: Aaron Merey <amerey@redhat.com>
> Date: Thu, 11 May 2023 19:22:03 -0400
> From: Aaron Merey via Gdb-patches <gdb-patches@sourceware.org>
> 
> This patch removes the possibility for clear_current_line to trigger the
> prompt by only printing chars_per_line - 1 blank spaces.  clear_current_line
> is only ever called to clear download progress bars, which do not print
> anything on the final character of a line.

I'm not sure we should rely on the fact that the final character of
the line is never there.  clear_current_line is a general-purpose
method, so it should do its job regardless.

Can't we do something to handle the last character as well?  E.g.,
could it be possible first to delete one character, so there are
really only N-1 characters to fill with blank spaces?

Thanks.