From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [209.51.188.92])
 by sourceware.org (Postfix) with ESMTPS id 3D7D13858D3C
 for <gdb-patches@sourceware.org>; Fri, 11 Mar 2022 20:02:22 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3D7D13858D3C
Received: from [2001:470:142:3::e] (port=59288 helo=fencepost.gnu.org)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nSlSv-0006uH-Lf; Fri, 11 Mar 2022 15:02:21 -0500
Received: from [87.69.77.57] (port=3613 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nSlSv-0001h4-1F; Fri, 11 Mar 2022 15:02:21 -0500
Date: Fri, 11 Mar 2022 22:02:21 +0200
Message-Id: <83h784cl6a.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <20220311185705.774197-1-tromey@adacore.com> (message from Tom
 Tromey via Gdb-patches on Fri, 11 Mar 2022 11:57:03 -0700)
Subject: Re: [PATCH v2 0/2] Make "set disable-randomization" work on Windows
References: <20220311185705.774197-1-tromey@adacore.com>
X-Spam-Status: No, score=1.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Mar 2022 20:02:23 -0000

> Date: Fri, 11 Mar 2022 11:57:03 -0700
> From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
> 
> Here's v2 of the series to make "set disable-randomization" work on
> Windows.
> 
> v1 was here:
> 
> https://sourceware.org/pipermail/gdb-patches/2021-October/182438.html
> 
> I believe this version addresses all the review comments.  In
> particular, it now dynamically checks for the needed APIs and should
> not need a newer version of Windows in order to build.
> 
> There are some caveats:
> 
> This passes regular testing against the AdaCore internal test suite.
> I've never gotten dejagnu to work on Windows, so I can't run the gdb
> test suite there.
> 
> I can no longer actually test whether ASLR disabling works, as it is
> globally disabled on all the Windows machines I can access.
> 
> I can't actually test building on an older version of Windows, so I
> don't know whether my attempts were actually successful.

Thanks, I just read the code, and it LGTM.  Will test when I have the
opportunity, probably when GDB 12 gets into pretest.