public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
Cc: palves@redhat.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] Readline: Cleanup some warnings
Date: Sun, 17 Mar 2019 18:35:00 -0000	[thread overview]
Message-ID: <83h8c1wdr5.fsf@gnu.org> (raw)
In-Reply-To: <87wokxtnlt.fsf@tromey.com> (message from Tom Tromey on Sun, 17	Mar 2019 11:30:38 -0600)

> From: Tom Tromey <tom@tromey.com>
> Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
> Date: Sun, 17 Mar 2019 11:30:38 -0600
> 
> I still don't really know what to do about the readline-related hack in
> the mingw gdb_select.  I'd like to remove it, but I can't test it and I
> don't know whether it's still needed.

Can someone point me to the PR that led to that hack?  I'd like to see
what happens in that use case and why is this code needed to solve it.
(I tried "git annotate", but that didn't tell me anything interesting
about the history of that snippet.  Apologies if I missed something.)

  reply	other threads:[~2019-03-17 18:35 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-30  8:57 Alan Hayward
2019-01-31  7:59 ` Joel Brobecker
2019-01-31 10:02   ` Alan Hayward
2019-01-31 17:24     ` Alan Hayward
2019-02-01  8:05       ` Joel Brobecker
2019-02-01 12:47         ` Tom Tromey
2019-02-01 18:54           ` Philippe Waroquiers
2019-02-06 19:56             ` Pedro Alves
2019-03-17 17:30               ` Tom Tromey
2019-03-17 18:35                 ` Eli Zaretskii [this message]
2019-03-19 16:04                   ` Tom Tromey
2019-03-19 18:37                     ` Eli Zaretskii
2019-03-19 19:02                     ` Pedro Alves
2019-03-19 19:04                       ` Pedro Alves
2019-03-19 20:14                       ` Eli Zaretskii
2019-03-20  8:55                         ` Eli Zaretskii
2019-03-20 15:46                         ` Pedro Alves
2019-03-20 15:50                           ` Pedro Alves
2019-03-20 17:39                           ` Eli Zaretskii
2019-03-20 17:50                             ` Pedro Alves
2019-03-20 18:01                               ` Eli Zaretskii
2019-03-20 18:28                                 ` Pedro Alves
2019-03-21 17:31                           ` Pedro Alves
2019-03-21 18:30                             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h8c1wdr5.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).