From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17502 invoked by alias); 17 Mar 2019 18:35:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17486 invoked by uid 89); 17 Mar 2019 18:35:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=UD:@sourceware.org, @sourceware.org, apologies, HX-Languages-Length:656 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 17 Mar 2019 18:35:31 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50860) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5ad6-0002qN-QQ; Sun, 17 Mar 2019 14:35:29 -0400 Received: from [176.228.60.248] (port=4793 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h5ad2-0004UB-NG; Sun, 17 Mar 2019 14:35:25 -0400 Date: Sun, 17 Mar 2019 18:35:00 -0000 Message-Id: <83h8c1wdr5.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey CC: palves@redhat.com, gdb-patches@sourceware.org In-reply-to: <87wokxtnlt.fsf@tromey.com> (message from Tom Tromey on Sun, 17 Mar 2019 11:30:38 -0600) Subject: Re: [PATCH] Readline: Cleanup some warnings References: <20190130085716.75179-1-alan.hayward@arm.com> <20190131075907.GA313@adacore.com> <3463805B-A8BF-4C20-ACE3-C21AE3F7DB62@arm.com> <20190201080533.GA31043@adacore.com> <877eejvfoq.fsf@tromey.com> <1549047248.2630.7.camel@skynet.be> <310315f8-62ab-2eff-042f-9f2ae9de07da@redhat.com> <87wokxtnlt.fsf@tromey.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00353.txt.bz2 > From: Tom Tromey > Cc: "gdb-patches\@sourceware.org" > Date: Sun, 17 Mar 2019 11:30:38 -0600 > > I still don't really know what to do about the readline-related hack in > the mingw gdb_select. I'd like to remove it, but I can't test it and I > don't know whether it's still needed. Can someone point me to the PR that led to that hack? I'd like to see what happens in that use case and why is this code needed to solve it. (I tried "git annotate", but that didn't tell me anything interesting about the history of that snippet. Apologies if I missed something.)