From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56352 invoked by alias); 2 Mar 2018 13:32:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56341 invoked by uid 89); 2 Mar 2018 13:32:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Mar 2018 13:32:42 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1erkng-0001iH-Ey for gdb-patches@sourceware.org; Fri, 02 Mar 2018 08:32:41 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57186) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erknP-0001Zt-GY; Fri, 02 Mar 2018 08:32:23 -0500 Received: from [176.228.60.248] (port=2379 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1erknN-0005Ea-Bk; Fri, 02 Mar 2018 08:32:22 -0500 Date: Fri, 02 Mar 2018 13:32:00 -0000 Message-Id: <83h8pywqku.fsf@gnu.org> From: Eli Zaretskii To: Sergio Durigan Junior CC: gdb-patches@sourceware.org, simon.marchi@ericsson.com, palves@redhat.com, brobecker@adacore.com, christophe.lyon@linaro.org In-reply-to: <20180301202005.11563-1-sergiodj@redhat.com> (message from Sergio Durigan Junior on Thu, 1 Mar 2018 15:20:05 -0500) Subject: Re: [PATCH] Conditionally include "" on common/pathstuff.c (and unbreak build on mingw*) Reply-to: Eli Zaretskii References: <20180301202005.11563-1-sergiodj@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00058.txt.bz2 > From: Sergio Durigan Junior > Cc: Simon Marchi , Pedro Alves , Joel Brobecker , Christophe Lyon , Sergio Durigan Junior > Date: Thu, 1 Mar 2018 15:20:05 -0500 > > +#ifdef USE_WIN32API > +#include > +#endif Isn't USE_WIN32API specific to gdbserver? If so, perhaps it's better to use __MINGW32__ or _WIN32 instead?