From: Eli Zaretskii <eliz@gnu.org>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: dje@google.com, gdb-patches@sourceware.org, palves@redhat.com
Subject: Re: [PATCH v2 4/4] btrace: add instruction-history /s and fix documentation
Date: Mon, 19 Oct 2015 09:37:00 -0000 [thread overview]
Message-ID: <83h9lngpwo.fsf@gnu.org> (raw)
In-Reply-To: <1445246610-11645-5-git-send-email-markus.t.metzger@intel.com>
> From: Markus Metzger <markus.t.metzger@intel.com>
> Cc: gdb-patches@sourceware.org, palves@redhat.com
> Date: Mon, 19 Oct 2015 11:23:30 +0200
>
> +It can also print mixed source+disassembly by specifying the @code{/m}
> +or @code{/s} modifier and print the raw instructions in hex as well as
> +in symbolic form by specifying the @code{/r} modifier.
"By specifying" makes it sound like you are talking about the command,
because of the "It" that starts the sentence. Suggest to reword:
It can also print mixed source+disassembly if you specify the @code{/m}
or @code{/s} modifier, and print the raw instructions in hex as well as
in symbolic form by specifying the @code{/r} modifier.
Note that I also added a missing comma before "and".
The documentation parts are okay with this fixed.
Thanks.
next prev parent reply other threads:[~2015-10-19 9:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 9:26 [PATCH v2 0/4] disasm, record: fix "record instruction-history /m" Markus Metzger
2015-10-19 9:23 ` [PATCH v2 3/4] btrace: change record instruction-history /m Markus Metzger
2015-10-26 3:47 ` Doug Evans
2015-10-26 12:55 ` Metzger, Markus T
2015-10-26 21:15 ` Doug Evans
2015-10-19 9:23 ` [PATCH v2 4/4] btrace: add instruction-history /s and fix documentation Markus Metzger
2015-10-19 9:37 ` Eli Zaretskii [this message]
2015-10-19 9:42 ` Metzger, Markus T
2015-10-26 3:47 ` Doug Evans
2015-10-19 9:26 ` [PATCH v2 1/4] disasm: split dump_insns Markus Metzger
2015-10-26 3:47 ` Doug Evans
2015-10-19 9:27 ` [PATCH v2 2/4] disasm: add struct disasm_insn to describe to-be-disassembled instruction Markus Metzger
2015-10-26 3:47 ` Doug Evans
2015-10-26 12:55 ` Metzger, Markus T
2015-10-26 20:57 ` Doug Evans
2015-10-26 3:47 ` [PATCH v2 0/4] disasm, record: fix "record instruction-history /m" Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h9lngpwo.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).