From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-126766-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 118714 invoked by alias); 19 Oct 2015 09:37:30 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 118702 invoked by uid 89); 19 Oct 2015 09:37:29 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout20.012.net.il
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Oct 2015 09:37:28 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NWG00700O15I600@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Mon, 19 Oct 2015 12:37:25 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NWG007S3O2CF520@a-mtaout20.012.net.il>; Mon, 19 Oct 2015 12:37:25 +0300 (IDT)
Date: Mon, 19 Oct 2015 09:37:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v2 4/4] btrace: add instruction-history /s and fix documentation
In-reply-to: <1445246610-11645-5-git-send-email-markus.t.metzger@intel.com>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: dje@google.com, gdb-patches@sourceware.org, palves@redhat.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83h9lngpwo.fsf@gnu.org>
References: <1445246610-11645-1-git-send-email-markus.t.metzger@intel.com> <1445246610-11645-5-git-send-email-markus.t.metzger@intel.com>
X-IsSubscribed: yes
X-SW-Source: 2015-10/txt/msg00330.txt.bz2

> From: Markus Metzger <markus.t.metzger@intel.com>
> Cc: gdb-patches@sourceware.org, palves@redhat.com
> Date: Mon, 19 Oct 2015 11:23:30 +0200
> 
> +It can also print mixed source+disassembly by specifying the @code{/m}
> +or @code{/s} modifier and print the raw instructions in hex as well as
> +in symbolic form by specifying the @code{/r} modifier.

"By specifying" makes it sound like you are talking about the command,
because of the "It" that starts the sentence.  Suggest to reword:

  It can also print mixed source+disassembly if you specify the @code{/m}
  or @code{/s} modifier, and print the raw instructions in hex as well as
  in symbolic form by specifying the @code{/r} modifier.

Note that I also added a missing comma before "and".

The documentation parts are okay with this fixed.

Thanks.