From: Eli Zaretskii <eliz@gnu.org>
To: Gary Benson <gbenson@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3 v2] Implement completion limiting
Date: Thu, 06 Nov 2014 16:28:00 -0000 [thread overview]
Message-ID: <83h9ycthsx.fsf@gnu.org> (raw)
In-Reply-To: <1415271046-4957-4-git-send-email-gbenson@redhat.com>
> From: Gary Benson <gbenson@redhat.com>
> Date: Thu, 6 Nov 2014 10:50:46 +0000
>
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
OK for this part.
> +void
> +_initialize_completer (void)
> +{
> + add_setshow_zuinteger_unlimited_cmd ("max-completions", no_class,
> + &max_completions, _("\
> +Set maximum number of line completion possibilities."), _("\
> +Show maximum number of line completion possibilities."), _("\
I suggest to use "completion candidates" instead of "line completion
possibilities".
> +Use this to limit the number of possibilities considered\n\
> +during line completion. Specifying \"unlimited\" or -1\n\
^^^^^^^^^^^^^^^
And here use just "completion". "Line completion" is IMO confusing,
since we don't complete "lines".
> +@table @code
> +@kindex set max-completions
> +@item set max-completions @var{limit}
> +@itemx set max-completions unlimited
> +Set the maximum number of possibilities to be considered during
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
"Candidates to be shown" is better.
> +completion. The default value is 200. Note that setting either
> +no limit or a very large limit can cause pauses during completion.
Not "cause pauses", but rather "make completion slow", I think.
> +@kindex show max-completions
> +@item show max-completions
> +Show the maximum number of possibilities to be considered during
> +completion.
Suggest the same change here as above.
The documentation part of the patch is OK with those changes.
Thanks.
next prev parent reply other threads:[~2014-11-06 16:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 10:50 [PATCH 0/3 v2] Limit tab-completion result when list is large Gary Benson
2014-11-06 10:51 ` [PATCH 3/3 v2] Implement completion limiting Gary Benson
2014-11-06 16:28 ` Eli Zaretskii [this message]
2014-11-21 10:46 ` Gary Benson
2014-11-24 6:09 ` Doug Evans
2014-11-06 10:51 ` [PATCH 1/3 v2] Add expansion_notify callback to expand_symtabs_matching Gary Benson
2014-11-06 10:51 ` [PATCH 2/3 v2] Interleave completion list building with symbol table expansion Gary Benson
2014-11-27 13:16 [PATCH 0/3 v2] Abort completion when list becomes large Gary Benson
2014-11-27 13:16 ` [PATCH 3/3 v2] Implement completion limiting Gary Benson
2014-11-27 16:25 ` Eli Zaretskii
2014-12-05 23:54 ` Doug Evans
2014-12-10 12:22 ` Gary Benson
2014-12-10 16:25 ` Doug Evans
2015-01-03 2:09 ` Doug Evans
2015-01-07 8:44 ` Gary Benson
2015-01-09 1:29 ` Doug Evans
2015-01-10 2:32 ` Doug Evans
2015-01-10 9:23 ` Eli Zaretskii
2015-01-12 18:50 ` Doug Evans
2015-01-15 15:39 ` Gary Benson
2015-01-23 7:32 ` Doug Evans
2015-01-23 10:59 ` Eli Zaretskii
2015-01-23 16:38 ` Doug Evans
2015-01-23 16:49 ` Eli Zaretskii
2015-01-23 20:28 ` Doug Evans
2015-01-24 1:55 ` Eli Zaretskii
2015-01-24 8:50 ` Doug Evans
2015-01-24 14:12 ` Eli Zaretskii
2015-01-25 15:55 ` Doug Evans
2015-01-25 19:14 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h9ycthsx.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).