From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12875 invoked by alias); 19 Nov 2010 22:14:22 -0000 Received: (qmail 12866 invoked by uid 22791); 19 Nov 2010 22:14:21 -0000 X-SWARE-Spam-Status: No, hits=-0.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Nov 2010 22:14:16 +0000 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LC500J00K5EB200@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Sat, 20 Nov 2010 00:13:58 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.52.47]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LC500JY1KF88U40@a-mtaout23.012.net.il>; Sat, 20 Nov 2010 00:13:58 +0200 (IST) Date: Fri, 19 Nov 2010 22:14:00 -0000 From: Eli Zaretskii Subject: Re: [2/2] RFA: --with-system-readline -vs- gdb.texinfo In-reply-to: To: Tom Tromey Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83hbfdarps.fsf@gnu.org> References: X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00272.txt.bz2 > From: Tom Tromey > Date: Fri, 19 Nov 2010 13:55:11 -0700 > > Currently if you configure with --with-system-readline, the resulting > gdb.info will still have its own copy of the readline manual. This is > the wrong thing to do -- the gdb readline might be a different version, > so the documentation might be misleading. > > This patch fixes the problem by making the uses of the included manual > conditional on whether --with-system-readline was given. > > This particular patch relies on removing gdb/doc/configure. > If that patch does not go in, I can change this one to suit. > > Tested by building both ways and looking at the appropriate nodes in the > resulting .info file. > > Please review. OK, thanks. > History expansion assigns special meaning to the character @kbd{!}. > -@xref{Event Designators}, for more details. > +@ifset SYSTEM_READLINE > +@xref{Using History Interactively, , , history, GNU History Library}, > +@end ifset > +@ifclear SYSTEM_READLINE > +@xref{Using History Interactively}, > +@end ifclear > +for more details. A copy/paste error?