Re: [patch] gdb-add-index tweaks

[Eli Zaretskii <eliz@gnu.org>]

> Date: Fri,  3 Sep 2010 11:01:17 -0700 (PDT)
> From: dje@google.com (Doug Evans)
> 
> This patch makes gdb-add-index.sh a (teensy) bit more robust
> and restores the Makefile.in/gdb.texinfo changes (the latter with
> a few tweaks).

Thanks.

> @@ -15230,8 +15230,8 @@ This computation does not apply to the `
>  When @value{GDBN} finds a symbol file, it scans the symbols in the
>  file in order to construct an internal symbol table.  This lets most
>  @value{GDBN} operations work quickly---at the cost of a delay early
> -on.  For large programs, this delay can be quite lengthy, so
> -@value{GDBN} provides a way to build an index, which speeds up
> +on.  For large programs this delay can be quite lengthy, so
> +@value{GDBN} provides a way to build an index which speeds up
>  startup.

I see no reason for this hunk of changes.  There's nothing wrong with
the original text.

>  There are currently some limitation on indices.  They only work when
> -for DWARF debugging information, not stabs.  And, they do not
> -currently work for programs using Ada.
> +using DWARF debugging information, not stabs.  And, they do not
> +currently work for programs written in Ada.

This is okay, but I would lose the "not stabs" part, because we
support more than just DWARF and stabs.  I understand that only DWARF
will enable this feature.

> +@value{GDBN} comes with a program, @command{gdb-add-index}, which can
> +be used to add the index to a symbol file.  It takes the symbol file
> +as its only argument:

We don't really explain what is a "symbol file".  But I guess this is
a problem with this entire chapter; feel free to fix that or leave it
as it is now.

> +@command{gdb-add-index} is a simple script, with minimal error checking.

If it's a script, why we say above that it's a program?